Fix nullish coalescing when the RHS is an object literal #516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #505
The RHS is meant to be transpiled into an expression arrow function, but if the
expression is an object literal, it gets interpreted as a block body. To fix, we
can unconditionally surround the arrow body in parens. This is a little ugly in
that it leaves an extra space, but avoiding that is probably more trouble than
it's worth.
Also fix two issues with test infra:
breaking change in Travis. Updated the yaml file to use
jobs
instead ofmatrix
, whichseems to work better.
like regex transformation and preset-env behavior). I was hoping to fix them by pinning the
dependencies or updating to latest Babel, but ended up just updating the expected test code
for now. I confirmed that this was a regression on the Babel end rather than anything caused by
a Sucrase change.