Implement optional chaining deletion #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangpierce
force-pushed
the
implement-optional-chaining-delete
branch
from
2414adf to
08b28bb
Compare
Codecov Report
@@ Coverage Diff @@
## master #492 +/- ##
==========================================
+ Coverage 82.37% 82.52% +0.14%
==========================================
Files 54 54
Lines 5276 5304 +28
Branches 1225 1236 +11
==========================================
+ Hits 4346 4377 +31
+ Misses 646 643 -3
Partials 284 284
Continue to review full report at Codecov.
|
Progress toward #461 Tech plan: https://github.com/alangpierce/sucrase/wiki/Sucrase-Optional-Chaining-and-Nullish-Coalescing-Technical-Plan This ended up being a relatively small tweak to the optional chaining implementation: * There's a new helper that wraps the optionalChain helper, and I needed to add a way for helpers to depend on each other. * In most cases, we condition on the delete and non-delete cases based on whether there's a delete token just before the start of the optional chain. * To determine whether a subscript is the last of its chain (and therefore needs a delete operation), we can walk the tokens forward tracking depth until we get to either another subscript or the end of the chain. This means there was no need for any changes to the parser. Since it only walks between two adjacent subscripts, it takes linear extra time unless there's nesting, and only ever does the more expensive operation when processing an optional delete.
alangpierce
force-pushed
the
implement-optional-chaining-delete
branch
from
08b28bb to
74371bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress toward #461
Tech plan: https://github.com/alangpierce/sucrase/wiki/Sucrase-Optional-Chaining-and-Nullish-Coalescing-Technical-Plan
This ended up being a relatively small tweak to the optional chaining
implementation:
a way for helpers to depend on each other.
whether there's a delete token just before the start of the optional chain.
a delete operation), we can walk the tokens forward tracking depth until we
get to either another subscript or the end of the chain. This means there was
no need for any changes to the parser. Since it only walks between two
adjacent subscripts, it takes linear extra time unless there's nesting, and only
ever does the more expensive operation when processing an optional delete.