Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port babel-parser changes from 2019-04-01 to 2019-09-06 #485

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

alangpierce
Copy link
Owner

Progress toward #483

c7587c016 Don't accept '\08' or '\09' in strict mode (#9769)
🚫 Validation change, not relevant for Sucrase.

508fde400 v7.4.3
🚫 Release only

338853b5d Fix parsing typescript bodiless methods with the estree plugin also enabled (#9890)
🚫 AST-only

4198d91b8 Fix: remove constant context type check for TS (#9869)
🚫 Validation-only

d7757f6d0 Fix TypeScript readonly error location (#9887)
🚫 Error-handling only

cf3668779 Always register global bindings as exportable (#9865)
🚫 Scope code not relevant to Sucrase

30d507c91 Add TS support to @babel/parser's Scope (#9766)
🚫 Sucrase deals with scope differently and generally doesn't need to implement
TS scope.

277a2620c allow directives and other comments before flow pragma (#9891)
🚫 We already remove all flow pragmas everywhere.

2c8869438 v7.4.4
🚫 Release only

555d50a08 Generate missing test output
🚫 Test only

354666aa1 fix: allow shebang directive (#9922)
🚫 We already handle shebangs and remove flow pragmas.

85432e2c4 Remove guardedHandlers from ASTs (#9979)
🚫 AST-only

47eb1ddfe Do not use lookahead when parsing dynamic import or import.meta (#9983)
✅ Implemented in a slightly different way with new tests.

4da7a01aa Avoid unnecessary work during lookahead (#9982)
🚫 Not relevant here

c2d303f8b Do not use lookahead when parsing declare module or declare module.exports in flow (#9985)
✅ Straightforward port.

5661de590 Do not use lookahead when parsing imports in declare module in flow (#9987)
🚫 Code removed from Sucrase.

3f0590de2 Do not use lookahead when parsing jsx expression containers (#9988)
✅ Ported in a similar way to original code.

b1826bf0a Only compute Position if not already in state (#9989)
🚫 Not relevant for Sucrase.

f5b814058 Do not use lookahead when parsing construct signature declarations (#9995)
✅ Ported in similar way to original code, removed unnecessary enum.

9c06e4ed4 avoid exceptions for control flow (#9974)
🚫 Sucrase already avoids exceptions.

54d257c10 Fix location for optional params in arrow functions (#9998)
🚫 AST-only change.

33ab4f166 v7.4.5
🚫 Release only.

888b9f694 Remove unused code in the TS parser plugin (#10025)
🚫 Already removed from Sucrase.

fdbbb743b flow - allow type parameter defaults in function declarations (#10084)
🚫 Nothing to do, we already allow defaults in function type parameters.

11fa2461c Disallow "let" as name at lexical bindings (#10099)
🚫 Validation-only.

1d3f9815d fix import typeof in declare module (#10132)
🚫 Code doesn't exist in Sucrase.

ca67637da [@babel/parser] Add "allowUndeclaredExports" option (#9864)
🚫 Validation-only.

8bf9714d6 [legacy decorators] Allow decorating generator methods (#9912)
🚫 Sucrase doesn't support legacy decorators.

6b8a37c41 Implement f# pipeline in parser (#9450)
🚫 I'll leave out support for F# pipelines for now.

0bf0ae341 Fix typos (#10153)
🚫 Not relevant for Sucrase.

f588e4ec4 BigInt type for Flow (#10091)
🚫 No changes necessary.

49da9a07c v7.5.0
🚫 Release only.

7f47cb65d Add Pipeline nodes to ast.spec [skip ci] (#10214)
🚫 Docs only.

d8da63c92 Use correct extension for typescript fixtures (#10014)
🚫 Test only.

0407f034f v7.5.5
🚫 Release only.

1e7ed5c46 Add allowUndeclaredExports option to typings. (#10263)
🚫 Types only.

f160522ab updated ParsePlugin type definition (#10259)
🚫 Types only.

4f0840ab8 Update dev dependencies and fix linting errors (#10228)
🚫 Formatting only.

75090f10e fix: assign comment to ObjectProperty only when inside an ObjectExpression (#10292)
🚫 Comment parsing only, not relevant for Sucrase.

15aa511b8 Do not register ambient classes to the TS scope (#10352)
🚫 Scope code not relevant for Sucrase.

1664cce68 Don't allow JSXNamespacedName to chain (#10366)
🚫 Validation only.

8a775a32b Retain trailing comments in array expressions (#10369)
🚫 Comment only.

c0e3fa008 Refactor trailing comma comment adjustment (#10380)
🚫 Comment only.

b02e35c19 Fix parenthesis for nullish coalescing (#10269)
✅ Updated precedence for operators.

da0af5fd9 V8intrinsic syntax plugin (#10148)
✅ Added case to the start of parseExprAtom.

c7587c016 Don't accept '\08' or '\09' in strict mode (#9769)
🚫 Validation change, not relevant for Sucrase.

508fde400 v7.4.3
🚫 Release only

338853b5d Fix parsing typescript bodiless methods with the estree plugin also enabled (#9890)
🚫 AST-only

4198d91b8 Fix: remove constant context type check for TS (#9869)
🚫 Validation-only

d7757f6d0 Fix TypeScript readonly error location (#9887)
🚫 Error-handling only

cf3668779 Always register global bindings as exportable (#9865)
🚫 Scope code not relevant to Sucrase

30d507c91 Add TS support to @babel/parser's Scope (#9766)
🚫 Sucrase deals with scope differently and generally doesn't need to implement
TS scope.

277a2620c allow directives and other comments before flow pragma (#9891)
🚫 We already remove all flow pragmas everywhere.

2c8869438 v7.4.4
🚫 Release only

555d50a08 Generate missing test output
🚫 Test only

354666aa1 fix: allow shebang directive (#9922)
🚫 We already handle shebangs and remove flow pragmas.

85432e2c4 Remove guardedHandlers from ASTs (#9979)
🚫 AST-only

47eb1ddfe Do not use lookahead when parsing dynamic import or import.meta (#9983)
✅ Implemented in a slightly different way with new tests.

4da7a01aa Avoid unnecessary work during lookahead (#9982)
🚫 Not relevant here

c2d303f8b Do not use lookahead when parsing declare module or declare module.exports in flow (#9985)
✅ Straightforward port.

5661de590 Do not use lookahead when parsing imports in declare module in flow (#9987)
🚫 Code removed from Sucrase.

3f0590de2 Do not use lookahead when parsing jsx expression containers (#9988)
✅ Ported in a similar way to original code.

b1826bf0a Only compute Position if not already in state (#9989)
🚫 Not relevant for Sucrase.

f5b814058 Do not use lookahead when parsing construct signature declarations (#9995)
✅ Ported in similar way to original code, removed unnecessary enum.

9c06e4ed4 avoid exceptions for control flow (#9974)
🚫 Sucrase already avoids exceptions.

54d257c10 Fix location for optional params in arrow functions (#9998)
🚫 AST-only change.

33ab4f166 v7.4.5
🚫 Release only.

888b9f694 Remove unused code in the TS parser plugin (#10025)
🚫 Already removed from Sucrase.

fdbbb743b flow - allow type parameter defaults in function declarations (#10084)
🚫 Nothing to do, we already allow defaults in function type parameters.

11fa2461c Disallow "let" as name at lexical bindings (#10099)
🚫 Validation-only.

1d3f9815d fix import typeof in declare module (#10132)
🚫 Code doesn't exist in Sucrase.

ca67637da [@babel/parser] Add "allowUndeclaredExports" option (#9864)
🚫 Validation-only.

8bf9714d6 [legacy decorators] Allow decorating generator methods (#9912)
🚫 Sucrase doesn't support legacy decorators.

6b8a37c41 Implement f# pipeline in parser (#9450)
🚫 I'll leave out support for F# pipelines for now.

0bf0ae341 Fix typos (#10153)
🚫 Not relevant for Sucrase.

f588e4ec4 BigInt type for Flow (#10091)
🚫 No changes necessary.

49da9a07c v7.5.0
🚫 Release only.

7f47cb65d Add Pipeline nodes to ast.spec (#10214)
🚫 Docs only.

d8da63c92 Use correct extension for typescript fixtures (#10014)
🚫 Test only.

0407f034f v7.5.5
🚫 Release only.

1e7ed5c46 Add `allowUndeclaredExports` option to typings. (#10263)
🚫 Types only.

f160522ab updated ParsePlugin type definition (#10259)
🚫 Types only.

4f0840ab8 Update dev dependencies and fix linting errors (#10228)
🚫 Formatting only.

75090f10e fix: assign comment to ObjectProperty only when inside an ObjectExpression (#10292)
🚫 Comment parsing only, not relevant for Sucrase.

15aa511b8 Do not register ambient classes to the TS scope (#10352)
🚫 Scope code not relevant for Sucrase.

1664cce68 Don't allow JSXNamespacedName to chain (#10366)
🚫 Validation only.

8a775a32b Retain trailing comments in array expressions (#10369)
🚫 Comment only.

c0e3fa008 Refactor trailing comma comment adjustment (#10380)
🚫 Comment only.

b02e35c19 Fix parenthesis for nullish coalescing (#10269)
✅ Updated precedence for operators.

da0af5fd9 V8intrinsic syntax plugin (#10148)
✅ Added case to the start of `parseExprAtom`.
@alangpierce alangpierce force-pushed the port-babel-changes-mid-2019-retry branch from f5be40f to bc6e848 Compare December 24, 2019 22:44
@codecov-io
Copy link

Codecov Report

Merging #485 into master will increase coverage by 0.14%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
+ Coverage   81.59%   81.74%   +0.14%     
==========================================
  Files          52       52              
  Lines        5200     5192       -8     
  Branches     1207     1206       -1     
==========================================
+ Hits         4243     4244       +1     
+ Misses        667      661       -6     
+ Partials      290      287       -3
Impacted Files Coverage Δ
src/parser/plugins/flow.ts 65% <0%> (+0.18%) ⬆️
src/parser/plugins/jsx/index.ts 92.8% <100%> (ø) ⬆️
src/parser/tokenizer/types.ts 58% <100%> (ø) ⬆️
src/parser/plugins/typescript.ts 80.11% <57.14%> (-0.15%) ⬇️
src/parser/traverser/expression.ts 84.24% <88.88%> (+1.43%) ⬆️
src/parser/tokenizer/index.ts 75.23% <0%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df7edd...bc6e848. Read the comment docs.

@alangpierce alangpierce merged commit ff0c26c into master Dec 24, 2019
@alangpierce alangpierce deleted the port-babel-changes-mid-2019-retry branch December 24, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants