Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build by disabling un-pinned babel test #480

Merged
merged 1 commit into from
Dec 23, 2019

Conversation

alangpierce
Copy link
Owner

It looks like a number of fixture tests were depending on core-js-compat in an
un-pinned way. Rather than trying to stay constantly up-to-date, this PR just
disables those tests, since there are plenty of other useful and reliable Babel
tests.

It looks like a number of fixture tests were depending on core-js-compat in an
un-pinned way. Rather than trying to stay constantly up-to-date, this PR just
disables those tests, since there are plenty of other useful and reliable Babel
tests.
@codecov-io
Copy link

Codecov Report

Merging #480 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
- Coverage   81.67%   81.59%   -0.08%     
==========================================
  Files          52       52              
  Lines        5429     5200     -229     
  Branches     1207     1207              
==========================================
- Hits         4434     4243     -191     
+ Misses        702      667      -35     
+ Partials      293      290       -3
Impacted Files Coverage Δ
src/Options-gen-types.ts 50% <0%> (-50%) ⬇️
src/util/getDeclarationInfo.ts 80% <0%> (-20%) ⬇️
src/util/elideImportEquals.ts 81.81% <0%> (-18.19%) ⬇️
src/parser/index.ts 77.77% <0%> (-7.94%) ⬇️
src/computeSourceMap.ts 83.33% <0%> (-5.56%) ⬇️
src/util/getNonTypeIdentifiers.ts 94.44% <0%> (-5.56%) ⬇️
src/parser/plugins/types.ts 91.66% <0%> (-3.34%) ⬇️
src/parser/tokenizer/readWord.ts 82.35% <0%> (-3.02%) ⬇️
src/util/shouldElideDefaultExport.ts 75% <0%> (-2.78%) ⬇️
src/parser/traverser/util.ts 86.2% <0%> (-2.17%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2956ca...1ac18ed. Read the comment docs.

@alangpierce alangpierce merged commit 6587019 into master Dec 23, 2019
@alangpierce alangpierce deleted the disable-unpinned-babel-tests branch December 23, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants