Add runtime validation for options #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #467 This uses the libraries ts-interface-builder and ts-interface-checker to codegen a data structure of the options TS type and then check it on every `transform` invocation. I tried a few approaches here, including generating JSON schema and then validating that, but that this seemed to be pretty smooth from a build system standpoint. I timed this on 1000 compilations of a large file and any difference was well within the time variability, so it seems fine to run this type validation on every `transform` invocation. It could potentially be moved out into a separate routine if perf is ever an issue, though.
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
==========================================
+ Coverage 81.42% 81.48% +0.05%
==========================================
Files 50 52 +2
Lines 5180 5200 +20
Branches 1208 1208
==========================================
+ Hits 4218 4237 +19
- Misses 669 671 +2
+ Partials 293 292 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #467
This uses the libraries ts-interface-builder and ts-interface-checker to codegen
a data structure of the options TS type and then check it on every
transforminvocation.
I tried a few approaches here, including generating JSON schema and then
validating that, but that this seemed to be pretty smooth from a build system
standpoint.
I timed this on 1000 compilations of a large file and any difference was well
within the time variability, so it seems fine to run this type validation on
every
transforminvocation. It could potentially be moved out into a separateroutine if perf is ever an issue, though.