Support .tsx and .jsx files from CLI #448
Conversation
Despite the transforms being supported, the CLI will currently only compile `.ts` files. This makes sure the correct file extensions are used when running something like `sucrase ./src -d ./out --transforms imports,typescript,jsx`.
There was a problem hiding this comment.
So sorry for the delay! #458 was just submitted, which is very similar to this one, so I'll accept this or the other one. Looks like this one has an undefined variable, crash though. (Would be nice if the CLI had tests, though I guess it did cause a CI failure because it's implicitly tested by the build system.)
|
Fixed - the other PR is almost exactly the same, only uses a regexp instead of |
|
Thanks! Looks like it was still having issues because it wasn't the full path, just the filename portion. I switched to the regex approach in the other PR, unclear which one is "best", but certainly the regex is a bit more concise. |
The array approach seems a little more extensible for future things like .mjs, for example.
There was a problem hiding this comment.
@ricardobeat sorry for the delay! I made one tweak and will merge when the build passes.
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
=======================================
Coverage 81.42% 81.42%
=======================================
Files 50 50
Lines 5180 5180
Branches 1208 1207 -1
=======================================
Hits 4218 4218
Misses 669 669
Partials 293 293
Continue to review full report at Codecov.
|
Despite the transforms being supported, the CLI will currently only compile
.tsfiles. This makes sure the correct file extensions are used when running something likesucrase ./src -d ./out --transforms imports,typescript,jsx.