Don't treat /*/ as an entire block comment
#430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #428 After seeing a `/*`, we were searching for a `*/`, but really we needed to search starting at two past the start of the comment.
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
==========================================
+ Coverage 80.07% 80.12% +0.04%
==========================================
Files 47 47
Lines 5040 5041 +1
Branches 1175 1175
==========================================
+ Hits 4036 4039 +3
+ Misses 702 700 -2
Partials 302 302
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #428
After seeing a
/*, we were searching for a*/, but really we needed tosearch starting at two past the start of the comment.