Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate helper code into its own file #419

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Conversation

alangpierce
Copy link
Owner

Now that we have four helpers and will soon be adding a fifth, it's nice to not
need a variable and lazy-getter for each one, so this puts them all in a file
that defines all helpers and coordinates those details.

This might be too dynamic to work in AssemblyScript, in which case I'd switch it
to use a codegen approach instead.

Now that we have four helpers and will soon be adding a fifth, it's nice to not
need a variable and lazy-getter for each one, so this puts them all in a file
that defines all helpers and coordinates those details.

This might be too dynamic to work in AssemblyScript, in which case I'd switch it
to use a codegen approach instead.
@codecov-io
Copy link

Codecov Report

Merging #419 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
+ Coverage   80.05%   80.09%   +0.03%     
==========================================
  Files          46       47       +1     
  Lines        5040     5264     +224     
  Branches     1180     1174       -6     
==========================================
+ Hits         4035     4216     +181     
- Misses        702      744      +42     
- Partials      303      304       +1
Impacted Files Coverage Δ
src/CJSImportProcessor.ts 91.66% <100%> (-0.3%) ⬇️
src/HelperManager.ts 100% <100%> (ø)
src/util/formatTokens.ts 70.58% <0%> (-10.06%) ⬇️
src/parser/util/identifier.ts 90.9% <0%> (-4.1%) ⬇️
src/parser/plugins/jsx/index.ts 87.33% <0%> (-1.88%) ⬇️
src/parser/plugins/flow.ts 62.21% <0%> (-1.59%) ⬇️
src/util/getClassInfo.ts 85.12% <0%> (-1.21%) ⬇️
src/identifyShadowedGlobals.ts 87.8% <0%> (-1.09%) ⬇️
src/parser/traverser/statement.ts 80.46% <0%> (-0.78%) ⬇️
src/util/isIdentifier.ts 100% <0%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ea989a...e03d8d7. Read the comment docs.

@alangpierce alangpierce merged commit d94e66f into master Feb 18, 2019
@alangpierce alangpierce deleted the consolidate-helpers branch February 18, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants