Implement react-hot-loader transform #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #228 Some details: * An eval snippet needed to be added to each class, which I decided to do unconditionally for simplicity. * A previous change already comptued the top-level declared variables, so I could just use those. * There was a bug where parameters in arrow function types were seen as top-level variables, so I changed it so types are never considered variable declarations. * In order to register the default export, we need to extract it to a variable, which required modifying both import transformers to handle that as a special case. * The ReactHotLoaderTransformer doesn't actually participate in normal transform, it just adds the snippets to the start and end. Cases not handled yet that could be handled in the future: * Avoid treating `require` statements as top-level declarations. * Skip react and react-hot-loader files themselves (Sucrase shouldn't be running on them anyway). I tested this end-to-end on a small app to make sure hot reloading works, including for bound methods.
Closed
Codecov Report
@@ Coverage Diff @@
## master #376 +/- ##
==========================================
+ Coverage 79.51% 79.73% +0.21%
==========================================
Files 44 45 +1
Lines 4877 5147 +270
Branches 1133 1144 +11
==========================================
+ Hits 3878 4104 +226
- Misses 702 743 +41
- Partials 297 300 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #228
Some details:
unconditionally for simplicity.
could just use those.
top-level variables, so I changed it so types are never considered variable
declarations.
which required modifying both import transformers to handle that as a special
case.
transform, it just adds the snippets to the start and end.
Cases not handled yet that could be handled in the future:
requirestatements as top-level declarations.on them anyway).
I tested this end-to-end on a small app to make sure hot reloading works,
including for bound methods.