Fix syntax error line numbers, delay computation #331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We internally throw and catch syntax errors in a number of cases, and from some
profiling work, a lot of the time was spent generating the line number from the
source code offset, which the user will never see. Now, we only include the line
and column numbers when the exception is thrown from the top level of the
parser.
Also, the code to compute line numbers was completely broken anyway (everything
was showing up as on the first line), so this fixes it and adds a test.