Restrict TS try/catch logic to cases where backtracking is needed #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #326 When porting some babel-parser changes, there was some code in TS parsing that was unconditionally wrapping some parsing in a try/catch, but actually it only cared about cases that started with `<`. By inverting the logic a little, we avoid having to throw and catch an exception in the common case of parsing, which was dramatically slowing down TypeScript parsing.
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
=========================================
- Coverage 76.62% 0% -76.63%
=========================================
Files 41 23 -18
Lines 5458 2074 -3384
Branches 1279 605 -674
=========================================
- Hits 4182 0 -4182
- Misses 900 2074 +1174
+ Partials 376 0 -376
Continue to review full report at Codecov.
|
|
Looks like something is buggy about coverage. I confirmed that it isn't related to this PR and filed as #329 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #326
When porting some babel-parser changes, there was some code in TS parsing that
was unconditionally wrapping some parsing in a try/catch, but actually it only
cared about cases that started with
<. By inverting the logic a little, weavoid having to throw and catch an exception in the common case of parsing,
which was dramatically slowing down TypeScript parsing.