Properly handle function name inference in named exports #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #307 Instead of writing `exports.f = () => {};`, we write `const f = () => {}; exports.f = f;` and still use `exports.f` for all writes and reads. This is a little odd in that the variable is never used, but it makes sure the export works fine. In the future, we possibly could refine it to only do a special case when the RHS is an unnamed function, but that's a bit harder to detect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #307
Instead of writing
exports.f = () => {};, we writeconst f = () => {}; exports.f = f;and still useexports.ffor all writesand reads. This is a little odd in that the variable is never used, but it makes
sure the export works fine. In the future, we possibly could refine it to only
do a special case when the RHS is an unnamed function, but that's a bit harder
to detect.