Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete cookiefile only with remove_entry #2502

Merged

Conversation

danielbrunt57
Copy link
Collaborator

Add async_remove_entry and move cookiefile deletion from async_unload_entry to async_remove_entry.

danielbrunt57 and others added 2 commits September 3, 2024 03:38
Add `async_remove_entry` and move cookiefile deletion from `async_unload_entry` to `async_remove_entry`.
@alandtse
Copy link
Owner

alandtse commented Sep 4, 2024

Where are these functions called? It seems weird that the fix for deleting too much is to write a new function remove_entry function. Is this a new HA function? If so, please provide a link to the dev docs or the github showing it was added. This may also require a HA version bump depending on when it was introduced.

@alandtse
Copy link
Owner

alandtse commented Sep 5, 2024

Nevermind, saw it in the linked issue.

@alandtse alandtse changed the title fix: cookiefile deletion should only occur when entry is removed fix: delete cookiefile only with remove_entry Sep 5, 2024
@alandtse alandtse merged commit c1229ca into alandtse:dev Sep 5, 2024
3 checks passed
@danielbrunt57
Copy link
Collaborator Author

I wish I could figure out how to terminate the http2 connection when the entry is removed.

The closest I can see is the close_callback=http2_close_handler but it's purpose seems to be to try and reconnect it when it closes rather than terminate it, and the await login_obj.close() doesn't end the HTTP2EchoClient process. It persists even after the config entry is removed...

@danielbrunt57 danielbrunt57 deleted the add_async-def-async_remove_entry branch September 13, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants