-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph visualisation & embedding dimensionality reduction #229
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Is this branched out of |
Looks good, notebooks run as expected and make very useful graphs for improving the model! Happy for this to be merged as long as it is added to the pipeline soon. I think all plots can be saved in the run directory (maybe under a subdirectory |
PR contribution summary
Why is this PR useful / good for? Please describe the problem(s) you're trying to address.
List of proposed changes / linked issues & discussions
logging
toLOGGER
to recycle its config #230What should a reviewer concentrate their feedback on?
infer_predictions.ipynb
What type of PR is this? (check all applicable)
Added tests?
PR review summary
Describe what this PR does & how you reviewed the individual items, where needed:
Some helper checks to tick off:
In conclusion, after my review, I'd like to: