Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph visualisation & embedding dimensionality reduction #229

Merged
merged 13 commits into from
Sep 12, 2023

Conversation

KristinaUlicna
Copy link
Collaborator

@KristinaUlicna KristinaUlicna commented Sep 11, 2023

PR contribution summary

Why is this PR useful / good for? Please describe the problem(s) you're trying to address.

  • This PR improves the evaluation of the trained GCN model:
  • Allows to visualise the node features / embeddings before & after the GCN
  • Allows to localise where in the graph the classifier makes errors, on per-node & per-edge basis.

List of proposed changes / linked issues & discussions

What should a reviewer concentrate their feedback on?

  • 🏃 Notebooks to run - particularly infer_predictions.ipynb
  • 💻 Code quality
  • 📝 Everything looks OK?

What type of PR is this? (check all applicable)

  • 🪄 Feature
  • 🧑‍💻 Code refactor / style
  • 🔥 Performance Improvements

Added tests?

  • 🙋 no, because I need some help

PR review summary

Describe what this PR does & how you reviewed the individual items, where needed:

Some helper checks to tick off:

  • Focus on image annotation
  • Focus on model training
  • Could any optimization be applied?
  • Is there any redundant code?
  • Are there any spelling errors?

In conclusion, after my review, I'd like to:

  • 🙋 ask some clarifying questions
  • 🙅 suggest some specific changes

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@KristinaUlicna KristinaUlicna marked this pull request as draft September 11, 2023 10:57
@KristinaUlicna KristinaUlicna self-assigned this Sep 11, 2023
@KristinaUlicna KristinaUlicna added enhancement New feature or request methodology Building functional & diverse pipeline labels Sep 11, 2023
@KristinaUlicna KristinaUlicna marked this pull request as ready for review September 11, 2023 19:57
@crangelsmith
Copy link
Collaborator

Is this branched out of inference? I see a lot of similar changes in the files changed. If so, maybe we could change the base for easier reviewing, or should I wait until PR #223 is merged?

@crangelsmith
Copy link
Collaborator

Looks good, notebooks run as expected and make very useful graphs for improving the model!

Happy for this to be merged as long as it is added to the pipeline soon. I think all plots can be saved in the run directory (maybe under a subdirectory plots). A function evaluation(graph, classifier) could be written more generally so it can be used to evaluate performance at epoch level (if that is useful), after training, as well as in an unseen graph.

@KristinaUlicna KristinaUlicna merged commit bd91bdf into main Sep 12, 2023
@KristinaUlicna KristinaUlicna deleted the dim-red-viz branch September 12, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request methodology Building functional & diverse pipeline
Projects
None yet
2 participants