Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training refactoring #303

Merged
merged 11 commits into from
Apr 24, 2024
Merged

Training refactoring #303

merged 11 commits into from
Apr 24, 2024

Conversation

crangelsmith
Copy link
Collaborator

@crangelsmith crangelsmith commented Mar 14, 2024

As described in #296, simplifying the training script to make it clear what is happening.

  • Moved model and optimiser configuration to its own files.
  • Created function for gamma/beta annealing configuration, and moved it to its own file.
  • Moved pass_batch functionally back to train.py and evaluation.py as it can be a bit confusing to see what is happening if is not explicit in the batch loop.
  • Aesthetic changes to make train.py script shorter.
  • Renamed variables for further clarity (e.g input_size to input_shape).
  • Added missing doctrings.
  • Updated readme with the latest configuration option and some aesthetic changes for readability (a lot more changes are needed to the README).

@crangelsmith crangelsmith changed the title [WIP] Training refactoring Training refactoring Mar 22, 2024
@crangelsmith crangelsmith mentioned this pull request Mar 22, 2024
4 tasks
@crangelsmith
Copy link
Collaborator Author

@jolaem would it be ok to merge this PR?

@crangelsmith
Copy link
Collaborator Author

I'll merge this now as is stopping further progress.

@crangelsmith crangelsmith merged commit 4e70bc2 into develop Apr 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant