Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ellipses to getMethylationStats #1

Closed

Conversation

bbarrilleaux
Copy link

I'm using methylKit 0.9.2, Rstudio 0.98.484, and R 3.0.2. Currently, if I try to override the default number of breaks for the histogram generated by getMethylationStats, it fails to pass the breaks argument on to the hist() function call that generates the labels.

For example, if I try:

data(methylKit)
getMethylationStats(methylRawList.obj[[1]],plot=TRUE,both.strands=FALSE,labels=TRUE, breaks = 5)
getMethylationStats(methylRawList.obj[[1]],plot=TRUE,both.strands=FALSE,labels=TRUE, breaks = 20)

the images come out with incorrect labels because it's generating 10 labels instead of 5 or 20:

breaks5
breaks20

I fixed the problem by adding ellipses to the label-generating hist() function call.

@al2na
Copy link
Owner

al2na commented Jan 9, 2014

this is great! thanks for fix. Could you make the changes to the "development" branch not to the master branch? and It would be great if you can:

  • bump up the version in the development branch to 0.9.2.1 in the DESCRIPTION file
  • add 0.9.2.1 to the NEWS file as well. Under IMPROVEMENTS AND BUG FIXES, describe what is fixed, you should also add "Contributed by biobonnie" or your real name.

I'm not terribly experienced with github but the reason I want to use the development branch for development is to make sure we only release a working version in the master branch after I do R CMD CHECK and make sure everything is working as intended. I will collect the changes made in the "development" branch after a while and test, and bump up the version and replace the master branch with the development.

@bbarrilleaux bbarrilleaux deleted the fix-getMethylationStats-args branch January 9, 2014 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants