Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wildcard imports #1485

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Fix wildcard imports #1485

merged 3 commits into from
Jan 8, 2024

Conversation

hmmbob
Copy link
Contributor

@hmmbob hmmbob commented Jan 6, 2024

Since 2024.1.1 HA warns for a lot of deprecated constants used by this component. These constants were imported with wildcards and mostly not even used. I had 3159 lines of warnings in my log. To fix this, I've removed all wildcard imports and replaced them with specific imports.

I only have a purifier device at home in use with this component, so the changes should be tested with other devices too.

Fixes #1483

@Necroneco
Copy link
Contributor

Necroneco commented Jan 7, 2024

seems missed __init__.py and core/miot_spec.py?

@hmmbob
Copy link
Contributor Author

hmmbob commented Jan 7, 2024

seems missed __init__.py and core/miot_spec.py?

Yeah, commit error yesterday. Was somewhat in a hurry, I've added them to the PR. Tx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecated constants
3 participants