Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes timeout parameter configurable #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

meghfossa
Copy link

@meghfossa meghfossa commented Mar 8, 2022

Hi team,

We would like to add timeout parameter for our usage. We are seeing frequent failure, which we think are reflated to timeout.

Reference: https://nodejs.org/api/child_process.html#child_processspawnsynccommand-args-options, denotes that spawnSync returns status field, which is the exit code of the subprocess, or null if the subprocess terminated due to a signal.

Example:

Overview

As a user, I would like to configure timeout parameter, so I can allow page configuration to more time.

Notes

I'm not sure how to unit-test and validate this, I'm not on windows.

@meghfossa
Copy link
Author

@al-cheb pinging your for review, even if you can bump the default timeout, it would help. Cheers!

@armanbilge
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants