Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: v5 issue fixes #1055

Merged
merged 34 commits into from
May 12, 2020
Merged

chore: v5 issue fixes #1055

merged 34 commits into from
May 12, 2020

Conversation

artyorsh
Copy link
Collaborator

@artyorsh artyorsh commented Apr 25, 2020

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

💣 BREAKING: refactor styled function to be decorator (#024ac83 Closes #1004)
Despite this is a breaking change, this helps us to keep the existing code base much cleaner by removing of styledComponentName statics. For the end user this also leads to better type definitions when using refs.

🐛 Bug Fixes:

📚 Documentation:

🚀 Features:

📝 Notes


Thanks everybody for giving v5 a try despite this was published as alpha!
Sharing your feedback and opening PRs and issues helps us grow faster 🚀

I hope we can close a few more issues in this PR and publish stable soon 🙌

@artyorsh artyorsh added 📱 Components components module-specific ➡️ Next Upcoming changes labels Apr 25, 2020
@artyorsh artyorsh requested a review from 32penkin April 25, 2020 17:36
@github-actions
Copy link

Try running it with Kitten Tricks

.

@artyorsh artyorsh changed the title [WIP]: v5 issue fixes [WIP] chore: v5 issue fixes Apr 26, 2020
@sldone
Copy link

sldone commented Apr 30, 2020

When this PR will be merged? I need a fix for #1015 without hacks

@artyorsh
Copy link
Collaborator Author

@sldone I want to keep this open for a week to solve some more issues before the version upgrade.

@sldone
Copy link

sldone commented Apr 30, 2020

@sldone I want to keep this open for a week to solve some more issues before the version upgrade.

thx for your answer :)

@artyorsh artyorsh merged commit 2cb0439 into next May 12, 2020
@artyorsh artyorsh deleted the chore/v5-issue-fixes branch May 12, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment