-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: v5 issue fixes #1055
Merged
Merged
chore: v5 issue fixes #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tyles" This reverts commit c2dbe54.
Try running it with Kitten Tricks |
This was
linked to
issues
Apr 26, 2020
Closed
Closed
2 tasks
When this PR will be merged? I need a fix for #1015 without hacks |
@sldone I want to keep this open for a week to solve some more issues before the version upgrade. |
thx for your answer :) |
32penkin
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
💣 BREAKING: refactor
styled
function to be decorator (#024ac83 Closes #1004)Despite this is a breaking change, this helps us to keep the existing code base much cleaner by removing of
styledComponentName
statics. For the end user this also leads to better type definitions when using refs.🐛 Bug Fixes:
Handle stateful (hook) components within the accessory and text props. (Closes v5 breaks support for functional components with hooks in accessories #1015)Closed by @Photonios #5ba8daf
onSelect
even when index is not changed. (#252a207 Closes Component: BottomNavigation onTabSelect() behaviour #977)onSubmitEditing
same way as v4 (#820328f Relevant Autocomplete has 3 problems : 2 steps of unfocusing, placement prop render problem and accesory prop not working #1025)📚 Documentation:
style
#1026)🚀 Features:
ImageComponent
property. (#ec76205 Closes FastImage for Avatar #999)autoDismiss
property` (#7208751 Closes Closing the calendar after onSelect event on Datapicker #1066)📝 Notes
shouldComponentUpdate
.Thanks everybody for giving v5 a try despite this was published as alpha!
Sharing your feedback and opening PRs and issues helps us grow faster 🚀
I hope we can close a few more issues in this PR and publish stable soon 🙌