Preserve selection when folding and unfolding blocks #95
Conversation
alexeyinkin
commented
Oct 26, 2022
alexeyinkin
commented
- Resolves Preserve selection when folding and unfolding #81
|
|
||
| // Linear interpolation search. | ||
| while (upperRange > lowerRange) { | ||
| // Full characters at the lower ange start and at the upper range end. |
| final range = ranges[rangeIndex]; | ||
|
|
||
| switch (range.compareToPosition(position)) { | ||
| case 0: |
There was a problem hiding this comment.
MAy be will be more readable, if numbers will be changed on "equals", "upper", and "lower"
There was a problem hiding this comment.
-1, 0, and 1 are common for sign-like methods.
| ); | ||
| }); | ||
|
|
||
| test('Cut with visible beginning and end', () { |
There was a problem hiding this comment.
This test does not cover case, where text contains hidden ranges at the start and at the end.
There was a problem hiding this comment.
Yes. This is the job for #27
Only with visible sections can the beginning be invisible.
| }; | ||
| int i = 0; | ||
|
|
||
| for (final example in examples.entries) { |
There was a problem hiding this comment.
this loop repeat the same at 68 line. Suggest to extract
| /// the visible text. | ||
| /// | ||
| /// If [position] is hidden, returns the last visible position before it. | ||
| int cutPosition(int position) { |
There was a problem hiding this comment.
May be better toHiddenPosition, toVisiblePosition? And also toHiddenSelection' and toVisibleSelection`.
There was a problem hiding this comment.
This is longer. cut... and recover... fit well.
| }); | ||
|
|
||
| group('Collapsed', () { | ||
| test('before ranges', () { |
There was a problem hiding this comment.
This 4 tests almost the same. Suggest to extract to a function and pass numbers as parameters
There was a problem hiding this comment.
Merged with the test below.
| ), | ||
| ]; | ||
|
|
||
| for (final selection in selections) { |
There was a problem hiding this comment.
May be this function helps to make this loop more clear
void _expectTheSame(TextSelection selection) {
expect(
HiddenRanges.empty.cutSelection(selection),
selection,
);
expect(
HiddenRanges.empty.recoverSelection(selection),
selection,
);
}
There was a problem hiding this comment.
This hides expect calls which is a bad pattern. They should be clearly visible. In 6 months when something breaks you will want to see expect on the top level.
