Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 241: Dispose suggestions popup #244

Merged
merged 5 commits into from
Jun 7, 2023
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/src/code_field/code_field.dart
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ class CodeField extends StatefulWidget {
this.onChanged,
@Deprecated('Use gutterStyle instead') this.lineNumbers,
@Deprecated('Use gutterStyle instead')
this.lineNumberStyle = const GutterStyle(),
this.lineNumberStyle = const GutterStyle(),
}) : assert(
gutterStyle == null || lineNumbers == null,
'Can not provide gutterStyle and lineNumbers at the same time. '
Expand Down Expand Up @@ -264,6 +264,7 @@ class _CodeFieldState extends State<CodeField> {
widget.controller.removeListener(_onTextChanged);
widget.controller.removeListener(_updatePopupOffset);
widget.controller.popupController.removeListener(_onPopupStateChanged);
_suggestionsPopup?.remove();
widget.controller.searchController.removeListener(
_onSearchControllerChange,
);
Expand Down