History controller fix #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yescorp
commented
Feb 9, 2023
| @@ -809,6 +809,7 @@ class CodeController extends TextEditingController { | |||
| @override | |||
| void dispose() { | |||
| _debounce?.cancel(); | |||
| historyController.dispose(); | |||
There was a problem hiding this comment.
Fixes all of the problems with disposing the timer in tests =)
Codecov Report
@@ Coverage Diff @@
## main #183 +/- ##
==========================================
+ Coverage 82.21% 82.26% +0.05%
==========================================
Files 85 85
Lines 2552 2560 +8
==========================================
+ Hits 2098 2106 +8
Misses 454 454
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
added 2 commits
February 13, 2023 10:45
|
Closing this PR because it is easier to create another branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changes history controller behavior: