Issue71_147 configure ci, clean up lints #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yescorp
commented
Jan 19, 2023
yescorp
commented
- Resolves configure pre-commit #71
- Resolves Clean up lints #147
yescorp
changed the title
added 2 commits
January 19, 2023 12:52
alexeyinkin
suggested changes
Jan 19, 2023
lib/src/folding/parsers/indent.dart
Outdated
Comment on lines
86
to
87
| final keys = _openBlocksLinesByIndent.keys.toList(); | ||
| for (int i = keys.length - 1; i >= 0; i--) { |
There was a problem hiding this comment.
Suggested change
| final keys = _openBlocksLinesByIndent.keys.toList(); | |
| for (int i = keys.length - 1; i >= 0; i--) { | |
| for (final indent in _openBlocksLinesByIndent.keys.reversed) { |
?
Make an extension getter reversed on Iterable. Make sure its .toList() is non-growable.
https://medium.com/flutter-senior/always-use-non-growable-arrays-if-possible-4864a022a54a
| //TODO(Malarg): handle scala multiline blocks | ||
| //https://github.com/akvelon/flutter-code-editor/issues/78. | ||
| // TODO(Malarg): handle scala multiline blocks | ||
| // https://github.com/akvelon/flutter-code-editor/issues/78. |
There was a problem hiding this comment.
Suggested change
| // https://github.com/akvelon/flutter-code-editor/issues/78. | |
| // https://github.com/akvelon/flutter-code-editor/issues/78 |
Some IDEs may treat . as a part of the URL.
added 2 commits
January 19, 2023 17:31
alexeyinkin
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.