New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HiddenLineRanges.cutLineIndexIfVisible (#112) #114

Merged

alexeyinkin merged 2 commits into main from issue112_cut-line-index-fix

Nov 8, 2022

Contributor

alexeyinkin commented Nov 7, 2022

Resolves HiddenLineRanges.cutLineIndexIfVisible bug with snippets.py #112


          Fix HiddenLineRanges.cutLineIndexIfVisible (#112)

42080e9

alexeyinkin requested a review from Malarg

November 7, 2022 15:18

Malarg approved these changes

View reviewed changes

lib/src/hidden_ranges/hidden_line_ranges.dart Outdated

-                  // upper == lower
-                  final breakpoint = breakpoints[upper];
-                  return breakpoint.cutLineIndexIfVisible(lineIndex);
+                  throw Exception('Never get here');

Collaborator

Malarg Nov 8, 2022

May be message of this exception should be more specific

alexeyinkin marked this pull request as ready for review

November 8, 2022 06:01


          Fix after review (#112)

64b6df4

alexeyinkin merged commit e545062 into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet