Fix after review (#97)

akvelon · Oct 31, 2022 · 78a0ee9 · 78a0ee9
1 parent 0c23cc6
commit 78a0ee9
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 15 deletions.
diff --git a/lib/src/code_field/text_editing_value.dart b/lib/src/code_field/text_editing_value.dart
@@ -152,18 +152,4 @@ extension TextEditingValueExtension on TextEditingValue {
     }
     return text.substring(selection.end);
   }
-
-  // These are used in tests only.
-
-  TextEditingValue replacedSelection(String text) {
-    return replaced(selection, text);
-  }
-
-  TextEditingValue typed(String text) {
-    final lengthDiff = text.length - selected.length;
-
-    return replaced(selection, text).copyWith(
-      selection: TextSelection.collapsed(offset: selection.end + lengthDiff),
-    );
-  }
 }
diff --git a/test/src/code_field/code_controller_folding_test.dart b/test/src/code_field/code_controller_folding_test.dart
@@ -1,8 +1,8 @@
 import 'package:flutter/widgets.dart';
-import 'package:flutter_code_editor/src/code_field/text_editing_value.dart';
 import 'package:flutter_test/flutter_test.dart';
 
 import '../common/create_app.dart';
+import '../common/text_editing_value.dart';
 import '../common/widget_tester.dart';
 
 const _code = '''

diff --git a/test/src/code_field/code_controller_hidden_ranges_test.dart b/test/src/code_field/code_controller_hidden_ranges_test.dart
@@ -5,6 +5,7 @@ import 'package:flutter_test/flutter_test.dart';
 import 'package:highlight/languages/java.dart';
 
 import '../common/create_app.dart';
+import '../common/text_editing_value.dart';
 
 const _text = '''
 // [START section2]

diff --git a/test/src/code_field/code_controller_readonly_test.dart b/test/src/code_field/code_controller_readonly_test.dart
@@ -5,6 +5,7 @@ import 'package:flutter_test/flutter_test.dart';
 import 'package:highlight/languages/java.dart';
 
 import '../common/create_app.dart';
+import '../common/text_editing_value.dart';
 
 const _editableBeginningEnd = '''
 abc

diff --git a/test/src/common/text_editing_value.dart b/test/src/common/text_editing_value.dart
@@ -0,0 +1,16 @@
+import 'package:flutter/widgets.dart';
+import 'package:flutter_code_editor/flutter_code_editor.dart';
+
+extension TextEditingValueTestExtension on TextEditingValue {
+  TextEditingValue replacedSelection(String text) {
+    return replaced(selection, text);
+  }
+
+  TextEditingValue typed(String text) {
+    final lengthDiff = text.length - selected.length;
+
+    return replaced(selection, text).copyWith(
+      selection: TextSelection.collapsed(offset: selection.end + lengthDiff),
+    );
+  }
+}
diff --git a/test/src/history/code_history_controller_test.dart b/test/src/history/code_history_controller_test.dart
@@ -9,6 +9,7 @@ import 'package:flutter_test/flutter_test.dart';
 
 import '../common/create_app.dart';
 import '../common/snippets.dart';
+import '../common/text_editing_value.dart';
 import '../common/widget_tester.dart';
 
 void main() {