-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong date string serialization in jsonschema #10
Comments
We are pretty aware that the main issue is in the SDK but we'll appreciate the workaround until they decide to fix it :) |
here is another workaround which can be applied in the tap configuration: (...)
stream_maps:
my_stream:
my_date: _['my_date'][0:10] Is this a reported issue in the SDK? I skimmed through the open issues and was not able to spot it right away. |
|
fixed upstream in the SDK meltano/sdk#2580 in and released with 0.39.1 https://github.com/meltano/sdk/releases/tag/v0.39.1 |
Ok, I'll try to update SDK in this project this weekend. |
Please check and reopen if the problem isn't fixed |
Hello,
We are finding an issue when dealing with Date columns due to String serialization.
In Meltano SDK, a Date it being serialized as f"{elem.isoformat()}T00:00:00+00:00" (https://github.com/meltano/sdk/blob/b02d698c15c1fff8667e18e5301c65a0fd0247b5/singer_sdk/helpers/_typing.py#L477-L478) which will always fail afterwards jsonschema validation, as the serialized string does not match jsconschema Date format (https://json-schema.org/understanding-json-schema/reference/string#dates-and-times).
Several taps have already implemented a workaround:
cc: @Plozano94
The text was updated successfully, but these errors were encountered: