-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy functionality not working properly in chrome. #35
Labels
bug
Something isn't working
Comments
Hi @sujeetvkulkarni. I cannot reproduce the error in chrome. |
Hi @akulmehta copy pop-up comes but if you try to paste the copied GlycoCT string on text editor it was not working. |
Sorry - can't reproduce yet. It copies it fine for me. I wonder if this is OS related - I am on Windows 10. |
Maybe I am on macOS Monterey Version 12.1 and Chrome Version 100.0.4896.75
(Official Build) (x86_64).
…On Thu, Apr 7, 2022 at 1:36 PM Akul Mehta ***@***.***> wrote:
Sorry - can't reproduce yet. It copies it fine for me. I wonder if this is
OS related - I am on Windows 10.
—
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADJ7PGXZRAMH27E5VTZCMNTVD4MKHANCNFSM5R3TT6UA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Does the code you proposed fix this for you? |
Yes, navigator.clipboard.writeText(text); function returns a promise object
and we should handle it with then construct before proceeding. That's what
the proposed code does.
…On Thu, Apr 7, 2022 at 1:45 PM Akul Mehta ***@***.***> wrote:
Does the code you proposed fix this for you?
—
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADJ7PGWHQ5OVDKHYQADGBMDVD4NLDANCNFSM5R3TT6UA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Copy functionality of GlycoCT sequence does not propelry in all browsers, specifically chrome.
/GlycoGlyphPublic/src/modules/copyTextFromElement.js
/GlycoGlyphPublic/public/js/glycoglyph.js
copyText() function should return promise object and copyTextFromElement should wait on the object. I have added modified code below,
//If you want to copyText from Element
function copyTextFromElement(elementID) {
let element = document.getElementById(elementID); //select the element
}
//If you only want to put some Text in the Clipboard just use this function
// and pass the string to copied as the argument.
function copyText(text) {
return navigator.clipboard.writeText(text);
}
The text was updated successfully, but these errors were encountered: