Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(directives): restore Chart.lock on no changes #2599

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented Sep 29, 2024

Fixes: #2226

@hiddeco hiddeco added this to the v0.9.0 milestone Sep 29, 2024
@hiddeco hiddeco self-assigned this Sep 29, 2024
@hiddeco hiddeco requested a review from a team as a code owner September 29, 2024 08:03
Copy link

netlify bot commented Sep 29, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 77f2ace
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66fa8afad33acf000844617b
😎 Deploy Preview https://deploy-preview-2599.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hiddeco hiddeco force-pushed the directives-restore-chart-lock branch from 9df9865 to c00bba0 Compare September 29, 2024 08:09
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 50.81967% with 30 lines in your changes missing coverage. Please review.

Project coverage is 51.07%. Comparing base (c21c4cf) to head (77f2ace).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
internal/directives/helm_chart_updater.go 50.81% 23 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2599      +/-   ##
==========================================
- Coverage   51.09%   51.07%   -0.03%     
==========================================
  Files         282      282              
  Lines       20950    21010      +60     
==========================================
+ Hits        10705    10731      +26     
- Misses       9580     9605      +25     
- Partials      665      674       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddeco hiddeco force-pushed the directives-restore-chart-lock branch from c00bba0 to 77f2ace Compare September 30, 2024 11:26
@hiddeco hiddeco added this pull request to the merge queue Sep 30, 2024
Merged via the queue into akuity:main with commit ae7b50b Sep 30, 2024
15 of 17 checks passed
@hiddeco hiddeco deleted the directives-restore-chart-lock branch September 30, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kargo updates helm timestamp every 5 minute with a new commit on GitHub pull request
2 participants