Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor #870 #886

Merged
merged 2 commits into from
Jul 2, 2016
Merged

refactor #870 #886

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b97e4d5
pull in navigationBarStyle and titleStyle from props.navigationState
joenoon Jun 30, 2016
036eeba
fix eslint warnings
joenoon Jun 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/TabbedView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ class TabbedView extends Component {
return;
}
this.renderedSceneKeys[key] = true;
scenes.push(this.renderScene(item, i));
const {navigationBarStyle,titleStyle} = this.props.navigationState;
scenes.push(this.renderScene({navigationBarStyle,titleStyle,...item}, i));
});
return (
<View style={this.props.style}>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as i've found today this commit broke my app :(

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aksonov sorry about that! what did it break?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right button style and overall style for own nav bar passed to Router globally

Pavel.

5 июля 2016 г., в 17:44, Joe Noon [email protected] написал(а):

In src/TabbedView.js:

@@ -54,7 +54,8 @@ class TabbedView extends Component {
return;
}
this.renderedSceneKeys[key] = true;

  •  scenes.push(this.renderScene(item, i));

  •  const {navigationBarStyle,titleStyle} = this.props.navigationState;

  •  scenes.push(this.renderScene({navigationBarStyle,titleStyle,...item}, i));
    });
    return (

    @aksonov sorry about that! what did it break?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Expand Down