❗️Hotfix - update react-native-experimental-navigation package

[jwarykowski]

Overview

Updated react-native-experimental-navigation to the latest version on the V3 branch, so that I can fix the trailing comma error which was reported and merged two months ago.

[aksonov]

LGTM!

[jwarykowski]

@aksonov thanks for the quick turnaround, if possible can you give me an ETA as to when you'll push this version to npm?

[aksonov]

Please check 3.44.0

…

24 сент. 2018 г., в 13:06, Jonathan Chrisp ***@***.***> написал(а): @aksonov <https://github.com/aksonov> thanks for the quick turnaround, if possible can you give me an ETA as to when you'll push this version to npm? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3290 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQpccGV-53CLrXurJU2We5Ge59QNFr4ks5ueLzCgaJpZM4W2Vl4>.

[jwarykowski]

Hey @aksonov, thanks for pushing this so quickly. I've tested and found a new issue when building the project. We get a naming collision as defined below. I'm running the latest version of react-native.

Loading dependency graph...(node:45537) UnhandledPromiseRejectionWarning: Error: jest-haste-map: @providesModule naming collision:
  Duplicate module name: Sample
  Paths: /Users/jonathanchrisp/development/xxxx/xxxx/node_modules/react-native-router-flux/ReduxExample/node_modules/react-native/Libraries/Sample/package.json collides with /Users/jonathanchrisp/development/xxxx/xxxx/node_modules/react-native/Libraries/Sample/package.json
This error is caused by a @providesModule declaration with the same name across two different files.

Weirdly, looking at the current v3 branch I can't see this ReduxExample folder. Has this been added accidentally?

[jwarykowski]

Just to note, upon removing the folder everything builds as expected.

[aksonov]

Probably so. Feel free to submit PR. v3 is not supported

[jwarykowski]

Hi @aksonov, just to make sure, I just ran npm pack locally and didn't get the ReduxExample folder added to the tar package. If possible was this added by mistake when you pused the version earlier? I can't see how this got here otherwise, are you able to check whether you had this within your directory when you published the project?

[aksonov]

Strange. Check v3.44.1 now

[jwarykowski]

Hey @aksonov, just pulled down and retested/rebuilt and looks to be working as expected now. Thanks again for the prompt updates, we're looking to move off version 3 soon, hopefully one day you'll be able to remove this branch! 🍻