Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Router - sceneStyle must be View.propTypes.style #2522

Merged
merged 1 commit into from
Oct 22, 2017
Merged

[Fix] Router - sceneStyle must be View.propTypes.style #2522

merged 1 commit into from
Oct 22, 2017

Conversation

ovr
Copy link
Contributor

@ovr ovr commented Oct 19, 2017 •
edited
Loading

Hey!

I am interested to use result of StyleSheet.create for Router sceneStyle property but it's object for now, but should be another

Unexpected warning:

image

Thank

@ovr ovr changed the title [Fix] Router - sceneStyle must be View.propTypes.style WIP - [Fix] Router - sceneStyle must be View.propTypes.style Oct 19, 2017
@ovr
Copy link
Contributor Author

ovr commented Oct 19, 2017

Find strange comment on the network:

Warning: View.propTypes has been deprecated and will be removed in a future version of ReactNative. Use ViewPropTypes instead.

I will review..

@ovr
Copy link
Contributor Author

ovr commented Oct 19, 2017 •
edited
Loading

image

@ovr ovr changed the title WIP - [Fix] Router - sceneStyle must be View.propTypes.style [Fix] Router - sceneStyle must be View.propTypes.style Oct 20, 2017
@kesha-antonov
Copy link
Contributor

@aksonov Please merge

@aksonov aksonov merged commit bcb5e0a into aksonov:master Oct 22, 2017
@ovr ovr deleted the patch-1 branch October 22, 2017 20:33
mvanroon pushed a commit to mvanroon/react-native-router-flux that referenced this pull request Feb 15, 2018
@ovr @mvanroon
[Fix] Router - sceneStyle must be View.propTypes.style (aksonov#2522)
40d973b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ovr @kesha-antonov @aksonov