Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind ExRouteAdapter instance to render callbacks #245

Closed
wants to merge 1 commit into from
Closed

Bind ExRouteAdapter instance to render callbacks #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ExRouter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export class ExRouteAdapter {
}
this.route = route;
this.name = route.name;
if (props.title) this.route.title = props.title;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like I'm correcting something that should be handled earlier on in some other module, but this solves the issue with getting the parent route title.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below we have

this.title = props.title || route.title;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but this.title is on the ExRouteAdapter but the renderTitle callback is bound to this.route.

this.title = props.title || route.title;
if (!this.name){
throw new Error("name is not defined for route");
Expand All @@ -40,7 +41,7 @@ export class ExRouteAdapter {
this.renderRightButton = this.route.props.renderRightButton.bind(this.route);
}
if (this.route.props.renderTitle){
this.renderTitle = this.route.props.renderTitle.bind(this.route);
this.renderTitle = this.route.props.renderTitle.bind(this, this.route);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If route should be passed as the first argument to renderTitle then this update should be correct.

}
if (this.route.props.renderLeftButton){
this.renderLeftButton = this.route.props.renderLeftButton.bind(this.route);
Expand Down