Delete hideNavBar and replaced hideNavBar with child.hideNavBar

[MechanicKim]

Please refer to #1363

As I know, default value of scene property 'hideNavBar' is false.
So, I fixed two lines in a file 'Defaultrenderer.js'

Added information!

• To fix a problem about 'test' and 'jest', I updated some react packages.

[mention-bot]

@MechanicKim, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joenoon, @andyschwob and @mat2maa to be potential reviewers.

[joenoon]

I'm a few versions behind and a bit out of the loop on this project, so I could be wrong here. But removing deepestExplicitValueForKey seems to me like it would break a lot of functionality that used to be demoed in the Example app: Go to tabbar > push new scene > and then all of the variations of hideTabBar hideNavBar that persisted through additional scenes and correctly recoiled as they were popped off. I would just urge someone more current on the state of the project to double check this. #1330 #1363

[MechanicKim]

@joenoon
I wanna help something as a person who uses this package.
what can I do for it?

[joenoon]

@MechanicKim If I'm guessing, I think what you have is something like this:

- root hideNavBar=false
  - scene1 hideNavBar=false
  - scene2 hideNavBar=true
  - scene3 (unspecified hideNavBar)

And when you go Actions.scene3(), you notice it thinks hideNavBar == true

If that accurately describes the issue, that was how I intended hideNavBar and hideTabBar to work - they are inherited values. The deepestExplicitValueForKey function walks the scene tree to get the inherited value when it isn't explicitly defined. Those props are special/different than other props to get the navigation behavior in the "push new scene" demo. I would compare it to how the ios UINavigationController behaves as you push and pop scenes while setting navigationBarHidden and hidesBottomBarWhenPushed as you go.

So I guess a few things:

1. Am I describing the issue right?

2. If so, it would not be a bug, so would better documentation resolve this? (either explicitly set hideNavBar on scenes, or at least set hideNavBar=false on any scene following a hideNavBar=true so it goes back to false).

3. Or is this not a behavior people want? For my app this functionality is critical and everywhere, but I can work around it if the core library wants to remove it.

Also, I mentioned before I'm a few versions behind, so I'm kind of jogging my memory on this, and I can't vouch that this functionality hasn't been broken in the latest versions that I haven't seen yet.

[MechanicKim]

First, I'm sorry. I might not know the intention of this react native package well.
To build our application, we are using this package. I just felt strange about using navigation bar.
For example, some html form tags have their default prop values. If we don't change it, they keep the default value. I have been used to this way.

[joenoon]

@MechanicKim no need to be sorry! What do you think about the rest? Does my explanation solve your issue or is there still something that doesn't work for your app?

[MechanicKim]

Yes! I totally understood your explanation that is so clear. ^^ No problem in our application. I just felt a little strange. If I can contribute to this project in anyway, I hope to do it. Thank you so much! Have a nice day. 2016-11-25 1:28 GMT+09:00 Joe Noon <[email protected]>:

…

@MechanicKim <https://github.com/MechanicKim> no need to be sorry! What do you think about the rest? Does my explanation solve your issue or is there still something that doesn't work for your app? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1406 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALlkF8wg2iFLI3x1gdVPOXJtxm1usEoSks5rBbs8gaJpZM4K5JjC> .

[charpeni]

Unfortunately we can't update react-native without running react-native upgrade.

I fixed the CI in #1422, but if you want to update the example project you can do it in another PR and don't forget to run the upgrade command.

[charpeni]

Thank you @MechanicKim, your time is greatly appreciated.

I'll close this PR since it seems resolved, if you think it shouldn't be closed, please let me know.