-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributors wanted! #69
Comments
I'd be interested! I'm not sure how much time I can dedicate as well but since we're using this library in our production app I will probably be motivated to fix issues that arise |
I was thinking about trying to help with documentation. There's still an awful lot I don't understand about this component, but perhaps I could take a stab at rewriting the readme and you could review it. |
@MITDelian you are welcome (added) |
@chetstone You are welcome, help with documentation is really necessary. Btw, I've added you as collaborator as well. |
@aksonov I thought it might be helpful to have a chat room. I've seen gitter.im used often so I set one up. just might chat some things as I'm learning the component: https://gitter.im/aksonov/react-native-router-flux |
@MITDelian Thanks for the chatroom. See you there. |
@chetstone happy to help review as well. I'll spend some time this weekend really trying to understand the component. One of my major goals is to make integration with a pre-existing redux store much easier |
Happy to help out. Just picking up a project again that uses this, and found some incompatibility with the latest react-native. Thought I'd browse the issues to see if it's reported and found this issue. Even better if I can just fix it as soon as I understand the problem. |
@aksonov - I will be happy to help out. |
@thachp @markburns thanks for help. Please check latest issues and try to create PR for them. |
@smallsaucepan Yes, please. |
Hi @aksonov, I'm using react-native-router-flux in production and I would like to help when possible. |
@mmazzarolo You are welcome to help with README as well as other open issues. |
Who want to help and have time, please check #307 |
FYI. Collaborators are still wanted (who could regularly answer/resolve issues, propose PRs, review my changes, etc.). |
@aksonov I'd be interested in helping you as collaborator by managing issues, propose and review pull requests, documentation and unit tests as well. FYI, I'm one of the contributors of react-native-simple-router which is a simple and basic integration of the Navigation API. |
@charpeni You are welcome! Please check all issues marked with 'help wanted' and submit PR for any. |
I think everyone here (including me) was confusing collaborators/contributors. It seems @aksonov is just asking for help but is not asking about adding people as collaborators. BTW, you might want to follow the model of trusting/adding people based on their contributions here or elsewhere. E.g. Rubinius is contributor-friendly: It can be rewarding to be listed as a collaborator on a project and the trust can inspire people to contribute even more than the initial contribution. |
Actually I really want to add active collaborators as contributors. However so far I see situation when people want to become contributors initially, without any experience with PRs. Pavel.
|
@cridenour , @lynndylanhurley, @joenoon Would you like to be collaborators for this project? |
@lelandrichardson are you interesting to be collaborator? |
@aksonov sure, thanks. i'm using this project quite a bit so i hope to keep contributing regularly. |
@philipshurpik Philip, are you still using the component and want to be a collaborator? |
@aksonov yes, we use it in new version of our app ) |
@daisydon No, it is not supported yet, PR is welcome (as |
Wouldn't it make more sense to just allow a custom element instead of differentiating between images or text? I can imagine svg, small styled views etc.
… On 20 Jul 2017, at 09:23, Pavel Aksonov ***@***.***> wrote:
@daisydon No, it is not supported yet, PR is welcome (as titleImage prop)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@AlexDM0 It is supported already - renderTitle |
@aksonov I am interested. But as I don't have too much experience in this technology, so I would like to start with small tasks. Please let me know if there are any. |
@rajsuvariya Thanks! The most |
I am trying to change some code for my application. I am trying to change it inside myproject's /node_modules/react-native-router-flux/src/Router.js. But the same is not being reflected in the app. Then I tried to add just log inside App component like following, but even that is not working.
Then I completely removed the code of Router.js then also the app is working fine. How can I change the code inside node_module/router_flux and make it work in my application? |
@rajsuvariya Change RNRF package.json to point to src/index.js and restart packager. |
I've just marked all tasks anybody could help with PR as 'help wanted' |
@aksonov I don't know if I need to be a contributor, but I would love to try and help people with documentation issues and/or usability issues. Let me know what I can do and if I need a role. I will continue to try to get docs up to date as well and eventually can help with some PRs. Cheers |
@mcabs3 Thank you for your help. If you want you can also check tickets with 'help needed' tag |
@aksonov I'm using react-native-router-flux in my projects so I like to help as much as i can. |
@aksonov can you add me as a collaborator please? |
@mcabs3 Done. Feel free to close issues - most issues nowadays are questions... Maybe we have to redirect them to stackoverflow. |
@aksonov Hey. I am also interested in help if you still need it. I am already done some PRs and try to help people with issues in free time but it would be great if you will add me as a collaborator. |
If needed - I would like to help too - mainly keeping v3 and helping people around it - not sure if is something that you still wish - but since I see a lot of folks still using it, at least maintenance for a few basic issues would be nice while a major upgrade can't be done in most of the projects. Thoughts? |
@onrige Thanks! Just sent you the invitation. |
@daviscabral Could you show me your PRs first? v3 support would be great! |
Count me in! I believe one important thing to be done is manage the questions being asked here in github in the form of issues. They should be asked on gitter or stackoverflow. Maybe we could also add gh-pages and add some more examples and common problems/faq there? I’d be more than happy to help you out there |
Please do, it would great to manage questions
… 28 окт. 2017 г., в 15:26, Michiel van Roon ***@***.***> написал(а):
Count me in!
I believe one important thing to be done is manage the questions being asked here in github in the form of issues. They should be asked on gitter or stackoverflow. Maybe we could also add gh-pages and add some more examples and common problems/faq there? I’d be more than happy to help you out there
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Dear maintainers and supporters, I have vacation until the end of August. You are welcome to answer issues, submit/review/merge PRs, etc. |
Thank you and have a great time! |
If someone still wants to help, he can choose "help wanted" tag and work. Also I can pay for some issues from my opencollective budget. |
I noticed the issue about the current RNRF not being up to date with the latest react-navigation v3, as well as this issue about needing contributors, and I also noticed react-navigation issues about needing contributors, and also wanting to add a simpler api. My question: has there ever been talk of teaming up and merging the two libraries? |
@darrencruse I talked with some guys from react-navigation team two years ago. They don't want to use JSX as route declaration like RNRF does. However we also discussed possible splitting react-navigation into many modules (separate for router, separate for tabs, etc.), so RNRF could be implemented as router for react-navigation v3 now |
…EventWithCustomDimensionValues - implement trackMultiProductsPurchaseEventWithCustomDimensionValues
Help with RNRF v5 is needed: |
I want to make my and your development easier with this component, but i can't spend much time on it. I do my best to make the component better and more robust, thanks for everybody for created issues, it is very valuable!
Unfortunately, number of PRs is minimal, even more, some guys just silently clone the component (even not fork), add some improvements and start promoting it as own one even without preserving copyright (however thanks for mention me as person who "inspire" them ;). I believe it is wrong way for open source development, we need to unite all our efforts to create something really great.
If somebody wants to do many changes (fix issues, write docs/unit tests) without waiting me to accept it, i'm ready to add him as collaborator.
The text was updated successfully, but these errors were encountered: