-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError: undefined is not a function (evaluating 'addListener') with the new stable release of react-navigation (1.0.0) #2865
Comments
so i realice that you are using a fixed version of react navigation in your last release (1.0.0-22.beta) so the question is, is there a way to still using RNRF 4.0.0-beta.24 BUT using a fixed version (like 1.0.0-27.beta for example) ? because i need to use RNRF 4.0.0-beta.24 , i cannot upgrade to RNRF 4.0.0-beta.28 i mean, i think that is make no sence that 4.0.0-beta.24 uses ^1.0.0-beta19 (that will result in the installation of the last 1.0.0 release) and a newer version like 4.0.0-beta.28 uses a fixed lower version (1.0.0-beta.22) The main point of the issue is if you guys can mantain compatibility with the related dependencies kind regards |
Trying to make RNRF work with latest react-navigation... Any suggestions? |
I made react-native-router-flux on this version: |
Unfortunately, the RNRF has a poor documentation. In the 4.0.0-beta.30 version, even without using redux, there is an 'addListener' error. |
@sajaddp i setup my project without redux, why still has the addListener problem? |
It is because 1.x react-navigation introduced breaking changes, for external state management (so not only redux is affected). 2.x introducing more breaking changes. |
@NSShentu,
Can you get me a simple example? package.json: |
@sajaddp your code is simple enough... my Router is more complex... now i just try not to use the Actions.replace ... |
in my old project, use: "react-native-router-flux": "4.0.0-beta.24", they work well. |
@aksonov I'm not using redux, and I'm getting the same error. How can I get rid of this error? I'm only using react-native-router-flux |
…on 1.0.0 breaking changes)
Please try to reproduce it with Example project and latest version 4.0.0-beta.40. Feel free to open if the issue still exists |
Version
Im getting this error react-navigation/react-navigation#3416
the react native router flux uses internally as dependency "react-navigation": "^1.0.0-beta.19"
i am also using:
any ideas why im getting this?
im using redux thunk like this:
and this is the main app:
any idea? i have deleted node_modules and install all the packages again and now i have this problem..
Something weird is that im using yarn, so i do a yarn install, then yarn list and i get:
as depth 0 package..
that would probably cause some conflict.. but i dont know if react-native-router-flux install this package as a root package too.. or there is another dependency that is installing this package
EDIT!: The thing is that now RNRF installs react-navigation 1.0.0 that is a newer release, after that it was installing 1.0.0-beta.27
so .. my app works with a beta version but doesnt with a stable release ..
any idea of why i am having this problem? because the addListener function is something that RNRF handles internally, RNRF is on top of react-navigation..
is there a way to install RNRF 4.0.0-beta.24 with react-navigation 1.0.0-beta.27? Because the package.json of RFRF is using ^ for that dependency...
The text was updated successfully, but these errors were encountered: