Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Lines and Config Sizes don't get scraped with only default groups being used #1

Closed
waza-ari opened this issue Aug 17, 2024 · 2 comments · Fixed by #2
Closed
Assignees

Comments

@waza-ari
Copy link

Hi, first of all, thanks for your awesome project! Using oxidized in a small non-profit environment, being able to monitor this using Grafana and Prometheus is a piece that was missing - so far it's working great!

When using Oxidized without groups (all devices attached to the default) groups, the exporter will not export the stats for oxidized_device_config_lines (always 0) or oxidized_device_config_size (always 14, probably the 404 not found reply). I believe that this is related to this request:

req, err := http.NewRequest("GET", c.Url+"/"+"node/fetch/"+group+"/"+name, nil)

When not using groups, the URL is simply /node/fetch/<device_name>, there's no group in the path. /node/fetch/default/<device_name> yields a 404. When adding groups, the exporter works fine as is.

@rwxd rwxd self-assigned this Aug 17, 2024
@rwxd rwxd closed this as completed in #2 Aug 27, 2024
rwxd added a commit that referenced this issue Aug 27, 2024
fix: #1 - use differend endpoint if only default group
@rwxd
Copy link
Contributor

rwxd commented Aug 27, 2024

Hi, thanks for your feedback!

I've added a condition to change the URL when all devices are configured to the group default. Could you please try out version v1.0.3 and let me know if it works for you?

@waza-ari
Copy link
Author

Hi, thanks! I've added a group for our devices already, can't really test this in the existing environment anymore. However if I get the chance, I can setup a small lab to test it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants