-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed to notification on DeathWatch watching. #899
Conversation
@Aaronontheweb here we go |
// send DeathWatchNotification to self for all matching subjects | ||
// that are not child with existenceConfirmed = false because we could have been watching a | ||
// non-local ActorRef that had never resolved before the other node went down | ||
// When a parent is watching a child and it terminates due to AddressTerminated | ||
// it is removed by sending DeathWatchNotification with existenceConfirmed = true to support | ||
// immediate creation of child with same name. | ||
foreach (var a in watchedBy.Where(a => a.Path.Address == address)) | ||
foreach (var a in _state.GetWatching().Where(a => a.Path.Address == address)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So was this a bug that got added when we extracted the ActorCell
state, or has this been a persistent issue for some time? Only asking because it may explain some of the cluster deathwatch behavior I've observed during multi-node test runs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this was introduced about 29 days ago. It affects Cluster DeathWatch directly because a node that has been removed from the cluster can't tell the DeathWatchers from another node it's dead:)
Fixed to notification on DeathWatch watching.
Ohhh my bad, thanks! |
Also some boyscout cleanup