Fixed to notification on DeathWatch watching. #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Aaronontheweb here we go |
| // send DeathWatchNotification to self for all matching subjects | ||
| // that are not child with existenceConfirmed = false because we could have been watching a | ||
| // non-local ActorRef that had never resolved before the other node went down | ||
| // When a parent is watching a child and it terminates due to AddressTerminated | ||
| // it is removed by sending DeathWatchNotification with existenceConfirmed = true to support | ||
| // immediate creation of child with same name. | ||
| foreach (var a in watchedBy.Where(a => a.Path.Address == address)) | ||
| foreach (var a in _state.GetWatching().Where(a => a.Path.Address == address)) |
There was a problem hiding this comment.
So was this a bug that got added when we extracted the ActorCell state, or has this been a persistent issue for some time? Only asking because it may explain some of the cluster deathwatch behavior I've observed during multi-node test runs.
There was a problem hiding this comment.
Looks like this was introduced about 29 days ago. It affects Cluster DeathWatch directly because a node that has been removed from the cluster can't tell the DeathWatchers from another node it's dead:)
rogeralsing
added a commit
that referenced
this pull request
Apr 25, 2015
Fixed to notification on DeathWatch watching.
|
Ohhh my bad, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also some boyscout cleanup