897 NUnit TestKit #898
Merged
897 NUnit TestKit #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
welp, looks like we don't have a good excuse to keep shitting all over XUnit anymore :p Thanks for your submission! We'll bundle this as part of the v1.0.1 release next week along with the XUnit2 testkit in #888 cc @annymsMthd and @HCanber - does this look kosher to you? |
|
Looks good to me. Nice to see some NUnit up in here:) |
|
Seems like an unrelated test failure. Intermittent test? |
|
#888 has a fix for that one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an NUnit implementation of the TestKit.
Resolves #897 .