Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix async await when awaiting IO completion port based tasks #843

Merged
merged 1 commit into from
Apr 13, 2015
Merged

Hotfix async await when awaiting IO completion port based tasks #843

merged 1 commit into from
Apr 13, 2015

Conversation

rogeralsing
Copy link
Contributor

Another hotfix for async await.
Turns out when using the Suspend behavior and awaiting tasks that complete on IO completion ports, e.g. Task.Delay or IO operations, the current context was lost.
This PR fixes this.

@rogeralsing
Copy link
Contributor Author

Ty @nvivo for reporting this stuff

@rogeralsing
Copy link
Contributor Author

Do not merge until @nvivo confirms that this solves the issues in his app.

@nvivo
Copy link
Contributor

nvivo commented Apr 13, 2015

The fix seems to work. Didn't see any crashes in my app anymore using ReceiveActor and the async Receive handler.

rogeralsing added a commit that referenced this pull request Apr 13, 2015
…otfix

Hotfix async await when awaiting IO completion port based tasks
@rogeralsing rogeralsing merged commit 10b8fd7 into akkadotnet:dev Apr 13, 2015
@rogeralsing rogeralsing deleted the async-await-resume-mailbox-hotfix branch April 19, 2015 16:18
This was referenced Apr 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants