Akka.Persistence.SqlServer plugin #842
Conversation
| table-name = SnapshotStore | ||
| schema-name = dbo | ||
| auto-initialize = on | ||
| connection-string = ""Data Source=.\\SQLEXPRESS;Initial Catalog=AkkaPersistenceSqlServerSpecDb;Integrated Security=True"" |
There was a problem hiding this comment.
This needs to be configured somehow. we can't expect the build serer and users to have this specific setup. see HOCON comment below.
|
IMO, just to be on the safe side, we should escape schema and table names when building queries. |
|
As for configuration settings on connection strings, I guess we should complete the substitution support in HOCON. Maybe we can keep the current setup until we have the hocon bits in place |
|
.SLN file currently has an MSBUILD failure according to TeamCity - need to update PR accordingly |
Horusiath
force-pushed
the
akka-persistence-sqlserver
branch
from
205bcaa
to
2e69d5d
Compare
|
@Horusiath @rogeralsing Do you think it makes sense to also provide guidance on protecting the app config file? Whenever I deploy anything that has something sensitive like connection strings I always encrypted the config. I know other frameworks don't bother since it most shops that's an IT responsibility but that is not always the case. For the last 15 plus years I have been not only responsible for development but operations end and am alway concern about security. I am just sharing my thoughts. Once this has settled down I would love to see if that same thing could be done with Postgres and Cassandra. |
|
Build Server can't run MSBuild at the moment, according to the error log. Would you mind taking a look at the .SLn @Horusiath ? |
Horusiath
force-pushed
the
akka-persistence-sqlserver
branch
from
2e69d5d
to
911b0d3
Compare
|
@Aaronontheweb If fixed a sln file and build.cmd didn't notice any problems, so I guest it should be ok now. |
Horusiath
force-pushed
the
akka-persistence-sqlserver
branch
from
911b0d3
to
3fcbd7c
Compare
|
Can this be merged or do we have to wait for sql support to be installed on the build server? |
|
@rogeralsing I need some instructions from @Horusiath on how to update the build agents first |
Horusiath
force-pushed
the
akka-persistence-sqlserver
branch
from
3fcbd7c
to
d626715
Compare
sqlexpress based test database working SqlServerJournal, intializes SqlServerSnapshotStore initial impl of SqlServer snapshot store fixed rest of broken sql server snapshot store specs Akka.Persistence.SqlServer comments for public API final notest and docs for Akka.Persistence.SqlServer safe escape of SQL string formats + mdf based tests fixed sln file added Akka.Persistence.SqlServer ldf test database file modified FAKE script to skip Akka.Persistence.SqlServer on LocalDB not installed separate build task for sql server tests
Horusiath
force-pushed
the
akka-persistence-sqlserver
branch
from
d626715
to
c70fc13
Compare
|
As discussed with @Aaronontheweb I've created a separate build task ( cc #891 |
|
looking good buddy - looking forward to seeing this hit the airwaves in v1.0.1 |
Akka.Persistence.SqlServer plugin
|
@Horusiath one minor thing - I believe we need a .nuspec file for this :p |
This PR introduces plugin with support for persistent Journal and Snapshot Store backed by SqlServer database.
Test cases by default assume that test database (named:Tests usesAkkaPersistenceSqlServerSpecDb) already exists on.\SQL-EXPRESSserverAkkaPersistenceSqlServerSpecDb.mdfdatabase file located in Akka.Persistence.SqlServer.Tests/Resources directory.Akka.Persistence.TestKitbase specs in form ofJournalSpecandSnapshotStoreSpechas been changed to require to runInitialize()method at the end of spec constructor in order to properly initialize the test cases [BREAKING CHANGE].cc #667