Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for Issues 832 & 833 #835

Merged
merged 1 commit into from
Apr 11, 2015

Conversation

jcwrequests
Copy link

Based @rogeralsing suggestion I removed the using a string to produce the actor and am instead using the type. This should resolve the issues with 832 & 833. @nvivo @Danthar could you please check this version to see if it resolves your issues. Thanks

@Aaronontheweb
Copy link
Member

@jcwrequests looks good to me. If @nvivo or @Danthar have anything to add they can chime in here. Will pull this in on Monday.

@nvivo
Copy link
Contributor

nvivo commented Apr 11, 2015

Looks good by reading, but I couldn't test it yet. Would be nice to have a new "rc" on nuget before releasing the next version, so we can better check this and the other issues.

One note is that I think there are some comments or text files in a folder somewhere in the tree that explains how to create a resolver that might need an update after this.

@Aaronontheweb
Copy link
Member

@nvivo we had a preview release of this up on NuGet about a week before the official release http://www.nuget.org/packages/Akka/1.0.0-dev1504032244

Each PR, when successful, also generates NuGet packages you can download as artifacts off of TeamCity.

But you're right - for longer term releases we should probably put weekly pre-releases out there rather than depend on people compiling from source.

@Aaronontheweb
Copy link
Member

And thanks for doing your review too @nvivo - much appreciated!

@jcwrequests
Copy link
Author

@nvivo @Aaronontheweb you are probably right about the docs I will double check. BTW @nvivo sorry about the earlier confusion about your suggestion. I was in the middle of doing work around the house and was trying to review everything from my phone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants