Fixed DDataShardCoordinator NullReferenceException #6892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Couldn't get Verify to work locally - I have no idea why |
Aaronontheweb
commented
Aug 24, 2023
| @@ -405,7 +408,7 @@ bool Receive(object message) | |||
| return true; | |||
|
|
|||
| case RememberEntitiesCoordinatorStore.UpdateDone m: | |||
| if (!shardId.Contains(m.ShardId)) | |||
| if (shardId != null && !shardId.Equals(m.ShardId)) | |||
There was a problem hiding this comment.
These checks are the key bug fixes - enabling nullability made them easy to spot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This code was not handling null checks appropriately - enabled
nullabilityfor both shard coordinators and found the problem.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):