-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ReceiveAsync resetting ReceiveTimeout #6718
Fix ReceiveAsync resetting ReceiveTimeout #6718
Conversation
@@ -162,7 +162,7 @@ public static void RunTask(Func<Task> asyncAction) | |||
if (exception == null) | |||
{ | |||
dispatcher.Resume(context); | |||
context.CheckReceiveTimeout(); | |||
context.CheckReceiveTimeout(context.CurrentMessage is not INotInfluenceReceiveTimeout); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reschedule
flag defaults to true
, if we don't set this, ReceiveAsync
will always resets receive timeout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -162,7 +162,7 @@ public static void RunTask(Func<Task> asyncAction) | |||
if (exception == null) | |||
{ | |||
dispatcher.Resume(context); | |||
context.CheckReceiveTimeout(); | |||
context.CheckReceiveTimeout(context.CurrentMessage is not INotInfluenceReceiveTimeout); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #6653
Changes
CheackReceiveTimeout
from resetting every time.