Delete unnecessary / bad Sql.Common.Journal subscriptions #6412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
added
akka-persistence-sql-common
Aaronontheweb
commented
Feb 17, 2023
| @@ -91,9 +91,6 @@ namespace Akka.Persistence.Sql.Common.Journal | |||
| protected virtual string ByPersistenceIdSql { get; } | |||
| protected virtual string ByTagSql { get; } | |||
| protected virtual string DeleteBatchSql { get; } | |||
| protected bool HasNewEventsSubscribers { get; } | |||
There was a problem hiding this comment.
No longer need these defined on the journal implementations. Could add these back to be non-breaking, but they're obsolete now regardless and not used anywhere inside the journal.
| @@ -91,6 +74,10 @@ protected override bool ReceivePluginInternal(object message) | |||
| { | |||
| switch (message) | |||
| { | |||
| case SelectCurrentPersistenceIds msg: | |||
There was a problem hiding this comment.
Added support for proper database polling here.
|
FWIW, the Akka.Persistence.Sqlite.Tests project covers all of these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
All of the old SubscribeTo___ methods from the Akka.Persistence.Sql.Common journal implement some bad practices, i.e. not able to detect events published in other instances of the Akka.NET processes targeting the same journal. This method deletes them and marks the old queries in Sql.Common as
Obsolete. Rewrote existing queries to poll the database rather than rely on in-memory events, which is the correct way to implement these.Also: significantly reduces allocations and overheads for writes for all Akka.Persistence.Sql.Common implementations.
Related: #5522
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):