Separate wire protocol from internal models #6206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
requested changes
Oct 21, 2022
src/contrib/cluster/Akka.Cluster.Metrics/Serialization/Proto/ClusterMetricsMessages.proto
Outdated
Show resolved
Hide resolved
|
OK, fixxed. Moved the .proto file to the general protobuf folder, modified the build script, and moved the proto classes to the standardized |
Aaronontheweb
approved these changes
Oct 27, 2022
|
This definitely passes wire compat now - wire types are unchanged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Separate Akka.Cluster.Metrics wire format model from internal model.
We were using the proto generated classes before. All protobuf generated codes are now internal.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):