Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DbCommand.CommandTimeout #6175

Conversation

Arkatufus
Copy link
Contributor

Fixes #6174

@@ -974,7 +974,7 @@ private async Task<BatchComplete> ExecuteChunk(RequestChunk chunk, IActorContext
using (var tx = connection.BeginTransaction(Setup.IsolationLevel))
using (var command = (TCommand)connection.CreateCommand())
{
command.CommandTimeout = (int)Setup.ConnectionTimeout.TotalMilliseconds;
command.CommandTimeout = (int)Setup.ConnectionTimeout.TotalSeconds;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DbCommand.CommandTimeout is expressed in seconds, not milliseconds.

@Aaronontheweb Aaronontheweb merged commit 695fada into akkadotnet:dev Oct 14, 2022
@Aaronontheweb
Copy link
Member

Needs to be backported to v1.4

Arkatufus added a commit to Arkatufus/akka.net that referenced this pull request Oct 14, 2022
Aaronontheweb pushed a commit that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection timeout is not respected for event journal commands when using BatchingSqlJournal
2 participants