Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Akka.Remote.Tests to async - Assorted small changes #5891

Merged
merged 5 commits into from
Apr 28, 2022
Merged

Convert Akka.Remote.Tests to async - Assorted small changes #5891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7514c95
Convert Akka.Remote.Tests to async - AddressUidExtensionSpecs
Arkatufus Apr 26, 2022
a10e679
Convert Akka.Remote.Tests to async - RemoteDaemonSpec
Arkatufus Apr 26, 2022
fea26de
Merge branch 'feature/async_testkit' into async_testkit/convert_Akka.…
Arkatufus Apr 26, 2022
bf5eeaa
Merge branch 'feature/async_testkit' into async_testkit/convert_Akka.…
Arkatufus Apr 26, 2022
93a4899
Merge branch 'feature/async_testkit' into async_testkit/convert_Akka.…
Aaronontheweb Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/Akka.Remote.Tests/AddressUidExtensionSpecs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public void AddressUidExtension_should_always_report_same_value()
}

[Fact]
public void AddressUidExtension_should_report_different_values_for_different_ActorSystems()
public async Task AddressUidExtension_should_report_different_values_for_different_ActorSystems()
{
var sys2 = ActorSystem.Create("Sys2");
try
Expand All @@ -45,7 +45,7 @@ public void AddressUidExtension_should_report_different_values_for_different_Act
}
finally
{
sys2.Terminate().Wait();
await ShutdownAsync(sys2);
}
}
}
Expand Down
5 changes: 3 additions & 2 deletions src/core/Akka.Remote.Tests/RemoteDaemonSpec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
//-----------------------------------------------------------------------

using System.Threading;
using System.Threading.Tasks;
using Akka.Actor;
using Akka.Actor.Internal;
using Akka.TestKit;
Expand Down Expand Up @@ -59,7 +60,7 @@ private static string GetConfig()
}

[Fact]
public void Can_create_actor_using_remote_daemon_and_interact_with_child()
public async Task Can_create_actor_using_remote_daemon_and_interact_with_child()
{
var p = CreateTestProbe();
Sys.EventStream.Subscribe(p.Ref, typeof(string));
Expand All @@ -82,7 +83,7 @@ public void Can_create_actor_using_remote_daemon_and_interact_with_child()
//pass a message to the child
child.Tell("hello");
//expect the child to forward the message to the eventstream
p.ExpectMsg("hello");
await p.ExpectMsgAsync("hello");
}
}
}
Expand Down