Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Async TestKit] Convert Akka.Remote.Tests to async - UntrustedSpec #5877

Merged
merged 3 commits into from
Apr 26, 2022
Merged

[Async TestKit] Convert Akka.Remote.Tests to async - UntrustedSpec #5877

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
109c647
Convert Akka.Remote.Tests to async - UntrustedSpec
Arkatufus Apr 25, 2022
7ca7a8e
Merge branch 'feature/async_testkit' into async_testkit/convert_Akka.…
Arkatufus Apr 25, 2022
06b40c9
Merge branch 'feature/async_testkit' into async_testkit/convert_Akka.…
Arkatufus Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
120 changes: 63 additions & 57 deletions src/core/Akka.Remote.Tests/UntrustedSpec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@ public class UntrustedSpec : AkkaSpec
private readonly ActorSystem _client;
private readonly Address _address;
private readonly IActorRef _receptionist;
private readonly Lazy<IActorRef> _remoteDaemon;
private readonly Lazy<IActorRef> _target2;


public UntrustedSpec(ITestOutputHelper output)
: base(@"
Expand All @@ -49,123 +46,124 @@ public UntrustedSpec(ITestOutputHelper output)
_address = Sys.AsInstanceOf<ExtendedActorSystem>().Provider.DefaultAddress;
_receptionist = Sys.ActorOf(Props.Create(() => new Receptionist(TestActor)), "receptionist");

_remoteDaemon = new Lazy<IActorRef>(() =>
{
var p = CreateTestProbe(_client);
_client.ActorSelection(new RootActorPath(_address)/_receptionist.Path.Elements)
.Tell(new IdentifyReq("/remote"), p.Ref);
return p.ExpectMsg<ActorIdentity>().Subject;
});

_target2 = new Lazy<IActorRef>(() =>
{
var p = CreateTestProbe(_client);
_client.ActorSelection(new RootActorPath(_address)/_receptionist.Path.Elements)
.Tell(new IdentifyReq("child2"), p.Ref);
EventFilter.Debug().Mute();
}

var actorRef = p.ExpectMsg<ActorIdentity>().Subject;
return actorRef;
});
private async Task<IActorRef> RemoteDaemon()
{
var p = CreateTestProbe(_client);
_client.ActorSelection(new RootActorPath(_address)/_receptionist.Path.Elements)
.Tell(new IdentifyReq("/remote"), p.Ref);
return (await p.ExpectMsgAsync<ActorIdentity>()).Subject;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

private async Task<IActorRef> Target2()
{
var p = CreateTestProbe(_client);
_client.ActorSelection(new RootActorPath(_address)/_receptionist.Path.Elements)
.Tell(new IdentifyReq("child2"), p.Ref);

EventFilter.Debug().Mute();
return (await p.ExpectMsgAsync<ActorIdentity>()).Subject;
}


protected override async Task AfterTerminationAsync()
protected override async Task AfterAllAsync()
{
await base.AfterAllAsync();
await ShutdownAsync(_client);
}


[Fact]
public void Untrusted_mode_must_allow_actor_selection_to_configured_white_list()
public async Task Untrusted_mode_must_allow_actor_selection_to_configured_white_list()
{
var sel = _client.ActorSelection(new RootActorPath(_address)/_receptionist.Path.Elements);
sel.Tell("hello");
ExpectMsg("hello");
await ExpectMsgAsync("hello");
}

[Fact]
public void Untrusted_mode_must_discard_harmful_messages_to_slash_remote()
public async Task Untrusted_mode_must_discard_harmful_messages_to_slash_remote()
{
var logProbe = CreateTestProbe();
// but instead install our own listener
Sys.EventStream.Subscribe(
Sys.ActorOf(Props.Create(() => new DebugSniffer(logProbe)).WithDeploy(Deploy.Local), "debugSniffer"),
typeof (Debug));

_remoteDaemon.Value.Tell("hello");
logProbe.ExpectMsg<Debug>();
var remoteDaemon = await RemoteDaemon();
remoteDaemon.Tell("hello");
await logProbe.ExpectMsgAsync<Debug>();
}

[Fact]
public void Untrusted_mode_must_discard_harmful_messages_to_test_actor()
public async Task Untrusted_mode_must_discard_harmful_messages_to_test_actor()
{
var target2 = _target2.Value;
var target2 = await Target2();
var remoteDaemon = await RemoteDaemon();

target2.Tell(new Terminated(_remoteDaemon.Value, true, false));
target2.Tell(new Terminated(remoteDaemon, true, false));
target2.Tell(PoisonPill.Instance);
_client.Stop(target2);
target2.Tell("blech");
ExpectMsg("blech");
await ExpectMsgAsync("blech");
}

[Fact]
public void Untrusted_mode_must_discard_watch_messages()
public async Task Untrusted_mode_must_discard_watch_messages()
{
var target2 = _target2.Value;
var target2 = await Target2();
_client.ActorOf(Props.Create(() => new Target2Watch(target2, TestActor)).WithDeploy(Deploy.Local));
_receptionist.Tell(new StopChild1("child2"));
ExpectMsg("child2 stopped");
await ExpectMsgAsync("child2 stopped");
// no Terminated msg, since watch was discarded
ExpectNoMsg(TimeSpan.FromSeconds(1));
await ExpectNoMsgAsync(TimeSpan.FromSeconds(1));
}

[Fact]
public void Untrusted_mode_must_discard_actor_selection()
public async Task Untrusted_mode_must_discard_actor_selection()
{
var sel = _client.ActorSelection(new RootActorPath(_address)/TestActor.Path.Elements);
sel.Tell("hello");
ExpectNoMsg(TimeSpan.FromSeconds(1));
await ExpectNoMsgAsync(TimeSpan.FromSeconds(1));
}

[Fact]
public void Untrusted_mode_must_discard_actor_selection_to_child_of_matching_white_list()
public async Task Untrusted_mode_must_discard_actor_selection_to_child_of_matching_white_list()
{
var sel = _client.ActorSelection(new RootActorPath(_address)/_receptionist.Path.Elements/"child1");
sel.Tell("hello");
ExpectNoMsg(TimeSpan.FromSeconds(1));
await ExpectNoMsgAsync(TimeSpan.FromSeconds(1));
}

[Fact]
public void Untrusted_mode_must_discard_actor_selection_with_wildcard()
public async Task Untrusted_mode_must_discard_actor_selection_with_wildcard()
{
var sel = _client.ActorSelection(new RootActorPath(_address)/_receptionist.Path.Elements/"*");
sel.Tell("hello");
ExpectNoMsg(TimeSpan.FromSeconds(1));
await ExpectNoMsgAsync(TimeSpan.FromSeconds(1));
}

[Fact]
public void Untrusted_mode_must_discard_actor_selection_containing_harmful_message()
public async Task Untrusted_mode_must_discard_actor_selection_containing_harmful_message()
{
var sel = _client.ActorSelection(new RootActorPath(_address)/_receptionist.Path.Elements);
sel.Tell(PoisonPill.Instance);
ExpectNoMsg(TimeSpan.FromSeconds(1));
await ExpectNoMsgAsync(TimeSpan.FromSeconds(1));
}


[Fact]
public void Untrusted_mode_must_discard_actor_selection_with_non_root_anchor()
public async Task Untrusted_mode_must_discard_actor_selection_with_non_root_anchor()
{
var p = CreateTestProbe(_client);
_client.ActorSelection(new RootActorPath(_address)/_receptionist.Path.Elements).Tell(
new Identify(null), p.Ref);
var clientReceptionistRef = p.ExpectMsg<ActorIdentity>().Subject;
_client.ActorSelection(new RootActorPath(_address)/_receptionist.Path.Elements)
.Tell(new Identify(null), p.Ref);
var clientReceptionistRef = (await p.ExpectMsgAsync<ActorIdentity>()).Subject;

var sel = ActorSelection(clientReceptionistRef, _receptionist.Path.ToStringWithoutAddress());
sel.Tell("hello");
ExpectNoMsg(TimeSpan.FromSeconds(1));
await ExpectNoMsgAsync(TimeSpan.FromSeconds(1));
}


Expand Down Expand Up @@ -205,14 +203,19 @@ public Receptionist(IActorRef testActor)

protected override bool Receive(object message)
{
return message.Match().With<IdentifyReq>(req =>
switch (message)
{
var actorSelection = Context.ActorSelection(req.Path);
actorSelection.Tell(new Identify(null), Sender);
})
.With<StopChild1>(child => { Context.Stop(Context.Child(child.Name)); })
.Default(o => { _testActor.Forward(o); })
.WasHandled;
case IdentifyReq req:
var actorSelection = Context.ActorSelection(req.Path);
actorSelection.Tell(new Identify(null), Sender);
return true;
case StopChild1 child:
Context.Stop(Context.Child(child.Name));
return true;
default:
_testActor.Forward(message);
return true;
}
}
}

Expand All @@ -233,7 +236,7 @@ protected override bool Receive(object message)

protected override void PostStop()
{
_testActor.Tell(string.Format("{0} stopped", Self.Path.Name));
_testActor.Tell($"{Self.Path.Name} stopped");
base.PostStop();
}
}
Expand Down Expand Up @@ -266,13 +269,16 @@ public DebugSniffer(TestProbe testProbe)

protected override bool Receive(object message)
{
return message.Match().With<Debug>(debug =>
if (message is Debug debug)
{
if (((string) debug.Message).Contains("dropping"))
{
_testProbe.Ref.Tell(debug);
}
}).WasHandled;
return true;
}

return false;
}
}

Expand Down