-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for possible broken documentation by failing on DocFX warning #5542
Check for possible broken documentation by failing on DocFX warning #5542
Conversation
@Arkatufus still need to add a step to the pr-validation AzDo file to enforce this |
Will this be helpful https://github.com/Ellerbach/docfx-companion-tools/tree/main/src/DocLinkChecker? |
@eaba DocFx already does this though - usually via build warnings. All we did was turn those into errors. |
@Arkatufus could you add the total number of warnings that need fixing to this PR and periodically update it as we reduce those? |
One thing we're probably doing to generate a lot of these warnings is not using |
Akka.DistributedData.Replicator.Messages.cs
#5634
Looks like incremental builds was one of the things really raising our error count. Disabling that eliminated a ton of them. |
* Moved the `akka core` configuration page into `modules`` (#5664) * Fix link issue with `xref` (#5666) Co-authored-by: Aaron Stannard <[email protected]> * [Docs]: Fix Metadata Reference (#5668) * Turn on `ProduceReferenceAssembly` * Add `ProduceReferenceAssembly` to `common.props` * Fix build failures in Akka.FSharp * Revert `<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>` added to affected projects because it already exists in `common.props' * Resolved invalid links (#5669) * Check for possible broken documentation by failing on DocFX warning (#5542) * Add --warningsAsErrors flag to DocFX * Add check in AzDo pr validation yaml * Use windows image for docfx test * Fix build script name * disable incremental builds for DocFx Co-authored-by: Aaron Stannard <[email protected]> * Removed internal copy of Nito.AsyncEx.AsyncContext, used the nuget package instead * Add asynchronous queue AsyncQueue to replace BlockingQueue * Remove <inheritdoc> XML doc tags, its causing DocFX crash Co-authored-by: Ebere Abanonu <[email protected]> Co-authored-by: Aaron Stannard <[email protected]> Co-authored-by: Gregorius Soedharmo <[email protected]>
* Moved the `akka core` configuration page into `modules`` (#5664) * Fix link issue with `xref` (#5666) Co-authored-by: Aaron Stannard <[email protected]> * [Docs]: Fix Metadata Reference (#5668) * Turn on `ProduceReferenceAssembly` * Add `ProduceReferenceAssembly` to `common.props` * Fix build failures in Akka.FSharp * Revert `<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>` added to affected projects because it already exists in `common.props' * Resolved invalid links (#5669) * Check for possible broken documentation by failing on DocFX warning (#5542) * Add --warningsAsErrors flag to DocFX * Add check in AzDo pr validation yaml * Use windows image for docfx test * Fix build script name * disable incremental builds for DocFx Co-authored-by: Aaron Stannard <[email protected]> * Make sure DocFX warning check step only executed in PR (#5674) * Make sure DocFX warning check step only executed in PR * Add run_if parameter to template Co-authored-by: Gregorius Soedharmo <[email protected]> * [Docs] Improve coordinated shutdown doc hygiene (#5677) * Extract hocon settings * Import coordinated shutdown phases using docfx code reference * Correct the usage of `integration` (#5679) * Improve code reference hygiene with exisiting code block (#5680) * Updated developement scenario (#5533) * Updated developement scenario * Fix markdown linting * Fix linting * Fix linting * Fix linting * Fix linting * Fix linting * Improve `toc.yml` for all sections * Console deployment * Sleep for 5 seconds * Add ASP.NET Core page * Fix startup issue * Fix typo * Fix linting issue * Fix trailing space * Added Headless Service * Fixed typo * Fix linting * * Resolves #5533 * Resolves #5533 * Fix linting * update solution projects * Fix invalid path * Solution project auto updated itself Co-authored-by: Aaron Stannard <[email protected]> * Fix ORSet.Merge with AddDeltaOperation takes too long to complete (#5686) * Fix ORSet.Merge with AddDeltaOperation takes too long to complete * Make sure that insertion is still correct after the changes * Increase update timeout setting Co-authored-by: Gregorius Soedharmo <[email protected]> * Make PipeTo ConfigureAwait() optional (#5684) * Remove ConfigureAwait() from PipeTo() * Remove ConfigureAwait() from PipeTo() * Add ConfigureAwait back to PipeTo, make it configurable instead * Update API Approval list * Add function overload for backward compatibility * Update API Approval list Co-authored-by: Gregorius Soedharmo <[email protected]> * Optimize PipeTo ConfigureAwait call (#5688) * Optimize PipeTo ConfigureAwait call * Inverse the double negative parameter Co-authored-by: Gregorius Soedharmo <[email protected]> * Fixed broken toc.yml (#5694) * Fix Serialization documentation discoverability (#5699) * Fix Serialization documentation discoverability * Rename Akka.IO * fixed name of serializer id table Co-authored-by: Aaron Stannard <[email protected]> * Call `base.AfterAll()` to kill TestKit ActorSystem (#5705) Co-authored-by: Gregorius Soedharmo <[email protected]> * Fix confusing logging when receiving gossip from unknown (#5706) * Reorder Source/FlowWithContext type parameters (#5648) Co-authored-by: Aaron Stannard <[email protected]> * Add Stateful methods for circuitbreaker (#5650) * Add Stateful methods for circuitbreaker * api docs * fix api docs Co-authored-by: Gregorius Soedharmo <[email protected]> Co-authored-by: Aaron Stannard <[email protected]> * Update RELEASE_NOTES.md for 1.4.34 release (#5707) Co-authored-by: Gregorius Soedharmo <[email protected]> * Added placeholder for 1.4.35 (#5709) * Fix PersistenceId Query and Sqlite unit tests (#5715) * Fix PersistenceId Query and Sqlite unit tests * Fix unit test assert * [DocFx] custom Akka.NET theme (#5659) * added updated Akka.NET DocFx theme * added "Show and Tell" page * added v1.5 notes * fix video embeds on mobile (#5719) * Fixed `IActorRef` leak inside `EventStream` (#5720) * reproduced #5717 Reproduced `IActorRef` leak inside the `EventStream` * cleaned up the `EventBusUnsubscriber` * close #5719 - cleaned up `EventStream` subscription management * added API approval For `Obsolete` attribute. * need to capture more data on why failures happen * harden bugfix5717specs * supress InvalidOperationException in xUnit OutputLogger (#5722) * Bump Google.Protobuf from 3.17.3 to 3.19.4 (#5555) Bumps [Google.Protobuf](https://github.com/protocolbuffers/protobuf) from 3.17.3 to 3.19.4. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Changelog](https://github.com/protocolbuffers/protobuf/blob/master/generate_changelog.py) - [Commits](protocolbuffers/protobuf@v3.17.3...v3.19.4) --- updated-dependencies: - dependency-name: Google.Protobuf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add MapMaterializedValue for Source/Flow WithContext (#5711) Co-authored-by: Gregorius Soedharmo <[email protected]> * close #5728 fix `ActorSystemSetup.And` (#5729) * Update RELEASE_NOTES.md for 1.4.35 release (#5726) * Update RELEASE_NOTES.md for 1.4.35 release * Update RELEASE_NOTES.md with the latest changes * v1.4.36 placeholder for nightlies (#5732) * Update PersistAsync to match docs. (#5736) This is supposed to be the example for persistAsync, but it doesn't get used at all. https://getakka.net/articles/persistence/event-sourcing.html#relaxed-local-consistency-requirements-and-high-throughput-use-cases I changed the code to match what is here: https://doc.akka.io/docs/akka/current/persistence.html#relaxed-local-consistency-requirements-and-high-throughput-use-cases * [DI] DI fails to throw an exception when DI tried to create an actor with missing constructor parameter (#5735) * Add bug spec for DI bug * Fix unit test to reflect the correct failure behaviour * Fix spelling (#5745) * Lock cspell on version `5.18.5` (#5744) * Lock cspell on version `5.18.5` * Use version `5.17.0` Co-authored-by: Aaron Stannard <[email protected]> * cleanup XUnit TestKit output logger (#5741) * marked `EventBusUnsubscriber` messages as `INoSerializationVerificationNeeded` (#5743) Eliminates issues with some `MinimalActorRef` actors subscribing to the `EventStream` when `akka.actor.serialize-messages = on`. * Fix MSBuild does not copy xunit.runner dlls correctly (#5747) * Add documentation on how to override serializer ids. (#5749) * Add `Member Roles` doc (#5742) * Add `Node Roles` doc Co-authored-by: Aaron Stannard <[email protected]> * [DOCS]: Add `Examples` section to Akka.NET Doc (#5739) * Add initial commit * Fix linting and spell checks * Update examples * Fix lint issues * Fix spell check - American English * fix examples href * Update page title * Updated page with more examples * Update examples.md * Fix lint and markdown errors. * Fix docs conflict * Fix blanks * Delete examples.md.orig Co-authored-by: Aaron Stannard <[email protected]> * Bump Hyperion to 0.12.2 (#5805) * Bump Hyperion to 0.12.2 * Add HyperionSerializerSettings immutable modifier methods * Fix unit tests * Fix leaky coordinated shutdown (#5816) * Fix CoordinatedShutdown infinite loop * Fix circular reference memory leak * Fix memory leak * Couple of fixes for the TcpConnection (#5817) * Fix TcpConnection error handling * Try not to get stopped by death pact before Unregistration is complete * Update RELEASE_NOTES.md for 1.4.36 release (#5820) * Revert changes that are unrelated to the memory leak (#5822) * Be more explicit that a node is shutting down as it was marked as DOWN (#5821) Co-authored-by: Aaron Stannard <[email protected]> * Change the failure log inside `AllEventPublisher` from Debug to Error (#5835) * Fix LeaseProvider instance Activator exception handling (#5838) * Make ActorSystemImpl.Abort skip the CoordinatedShutdown check (#5839) * Bump Microsoft.Data.SQLite from 5.0.11 to 6.0.4 (#5837) Bumps [Microsoft.Data.SQLite](https://github.com/dotnet/efcore) from 5.0.11 to 6.0.4. - [Release notes](https://github.com/dotnet/efcore/releases) - [Commits](dotnet/efcore@v5.0.11...v6.0.4) --- updated-dependencies: - dependency-name: Microsoft.Data.SQLite dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update RELEASE_NOTES.md for 1.4.37 release (#5841) * Add specs to test disallow-unsafe-type (#5746) * Add spec to test disallow-unsafe-type * Fix Hyperion disallow-unsafe-type spec * move from ApprovalTests to Verify for api tests (#5846) * approved to verified * move to verify * Update CoreAPISpec.cs * Update Akka.API.Tests.csproj * Update Akka.API.Tests.csproj * Update CoreAPISpec.cs * Bump FsCheckVersion from 2.16.3 to 2.16.4 (#5724) Bumps `FsCheckVersion` from 2.16.3 to 2.16.4. Updates `FsCheck` from 2.16.3 to 2.16.4 - [Release notes](https://github.com/fsharp/FsCheck/releases) - [Changelog](https://github.com/fscheck/FsCheck/blob/master/FsCheck%20Release%20Notes.md) - [Commits](fscheck/FsCheck@2.16.3...2.16.4) Updates `FsCheck.Xunit` from 2.16.3 to 2.16.4 - [Release notes](https://github.com/fsharp/FsCheck/releases) - [Changelog](https://github.com/fscheck/FsCheck/blob/master/FsCheck%20Release%20Notes.md) - [Commits](fscheck/FsCheck@2.16.3...2.16.4) --- updated-dependencies: - dependency-name: FsCheck dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: FsCheck.Xunit dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix Persistence.TCK specs (#5849) * DeleteMessagesFailure message should log its failure stack trace * Make JournalSpec facts overridable * Make error reporting standardized. * change `dev` version number to 1.5-x (#5856) * Zbynek001 sharding update2 (#5857) * Add Dropped to Akka.Actor (migrated partially from akka/akka#27160) Log Dropped from DeadLetterListener * Logging of UnhandledMessage (migrated from akka/akka#28414) * make use of the existing logging of dead letter also for UnhandledMessage Supress ActorSelectionMessage with DeadLetterSuppression (migrated from akka/akka#28341) * for example the Cluster InitJoin message is marked with DeadLetterSuppression but was anyway logged because sent with actorSelection * for other WrappedMessage than ActorSelectionMessage we shouldn't unwrap and publish the inner in SuppressedDeadLetter because that might loose some information * therefore those are silenced in the DeadLetterListener instead Better deadLetter logging of wrapped messages (migrated from akka/akka#28253) * MessageBuffer implementations * TestKit logger with prefix * sharding update * sharding tests * sharding multinode tests * api approval * replace sqlite with MemoryJournalShared and local snapshot store * tests * snapshot inmem * backwards compatible PersistenceId for PersistentShardCoordinator * test fix * SnapshotStoreProxy & MemorySnapshotStoreShared * test snapshot store switched to shared inmem * ExternalShardAllocationStrategy & tests * ExternalShardAllocationStrategy API approval * test timing fix * review comments addressed * IEquatable removed for singleton messages * test fixes * cleanup * test cleanup * protobuf generated * cleanup * cleanup * Race condition in DeprecatedSupervisionSpec fixed (migrated from akka/akka#29914) * cleanup * Small clarification of recovery strategy in config (migrated from akka/akka#30167) * Resolve snapshot check skipped for some events (migrated from akka/akka#30226) * additional sharding messages serialization, tests * api approval update * disable durable storage on ShardRegionSpec * extend timeout for ExternalShardAllocationSpec * naming conventions * missing readonly added, updated syntax * renaming conventions * Defer coordinator stop until region graceful stop has completed (migrated from akka/akka#30338) * sharding: actively signal 'region stopped' to the coordinator (migrated from akka/akka#30402) * racy test fix * racy test verbose logging * test update * merge fix * sharding ddata coordinator switch to ReadMajorityPlus/WriteMajorityPlus * more logs to debug tests * more logs * fix MultiNodeClusterSpec default timeouts * revert additional logs * override single-expect-default only for sharding tests * revert unrelated protobuf serializers * Fix StartEntitySpec instability (migrated from akka/akka#30537) The old logic allowed a race condition where the 'StartEntity' from the test arrived at the ShardRegion before the termination of the actor did, causing it to ignore the `StartEntity`. * Quieter logging for ShardCoordinator initialization (migrated from akka/akka#30488) Log the first retry on 'info', then 'warning', and finally 'error' * reduce default write-majority-plus for sharding (migrated from akka/akka#30328) * merge fix * rebalance log fix * fixed compilation error from rebase * switch RememberEntitiesShardIdExtractorChangeSpec from ddata to persistence * disable durable storage on PersistentShardingMigrationSpec * clean up leveldb configuration * fix XML-DOC warnings Co-authored-by: zbynek001 <[email protected]> Co-authored-by: Gregorius Soedharmo <[email protected]> * Bump Swashbuckle.AspNetCore from 6.2.3 to 6.3.0 (#5848) Bumps [Swashbuckle.AspNetCore](https://github.com/domaindrivendev/Swashbuckle.AspNetCore) from 6.2.3 to 6.3.0. - [Release notes](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/releases) - [Commits](domaindrivendev/Swashbuckle.AspNetCore@v6.2.3...v6.3.0) --- updated-dependencies: - dependency-name: Swashbuckle.AspNetCore dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * cleaned up some allocations and styling (#5855) * fix sharding recovery (#5863) * Update MNTR to 1.1.1 and update build script to suit (#5866) * GroupBy fixes (#5874) * Target incrementalist against v1.4 branch for v1.4 * Update MNTR to 1.1.1 and update build script to suit (#5867) (cherry picked from commit 2b4267e) * GroupBy pulls upstream when a substream materialization is waiting * Cancel GroupBy when all substreams cancel * Allow GroupBy to recreate already closed substreams * Fixes GroupBy does not invoke decider * Avoids memory being retained for GroupBy * Revert v1.4 merge * Fix markdownlint error Co-authored-by: Aaron Stannard <[email protected]> Co-authored-by: Gregorius Soedharmo <[email protected]> * Fix Source.ActorRef not completing (#5875) * Fix typo in `akka.remote.dot-netty.ssl.certificate` (#5895) * enable `ChannelTaskScheduler` to work inside Akka.Cluster without causing errors inside `/system` actors (#5861) (#5920) * close #5498 enable `ChannelTaskScheduler` to work inside Akka.Cluster without causing errors inside `/system` actors * fix `HeartbeatSender` * cleaned up SBR internals (style) * cleaned up some comments * asynchronously attempt to acquire `Cluster` inside SBR * fixed SBR compilation * Update SplitBrainResolver.cs * subscribe on PreStart * added .NET 6 dual targeting to all assemblies (#5926) * added .NET 6 dual targeting to all assemblies have not added and .NET 6-specific code yet, just added support for it in the build system * adding verify files per-runtime * added all .NET 6 files * moved files to their own folder * added all Verified files * Renamed method `SetHandler` accepting both callbacks to `SetHandlers` (#5931) * Rewrite actor ref sink as a graph stage (#5930) Co-authored-by: Aaron Stannard <[email protected]> * Post-merge cleanup * Update API verify list * Post-merge fix and update API verify list * Fix XML doc * Post merge fix, docs * Fix XML Doc * Post merge fix * Post merge fix Co-authored-by: Ebere Abanonu <[email protected]> Co-authored-by: Aaron Stannard <[email protected]> Co-authored-by: Gregorius Soedharmo <[email protected]> Co-authored-by: Ismael Hamed <[email protected]> Co-authored-by: Drew <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adrian Leonhard <[email protected]> Co-authored-by: Simon Cropp <[email protected]> Co-authored-by: zbynek001 <[email protected]>
#5953) * Add peek methods into BlockingQueue and TestKitBase (#5660) * Add peek methods into BlockingQueue and TestKitBase * Add Obsolete attribute to BlockingQueue.AddFirst Co-authored-by: Gregorius Soedharmo <[email protected]> * Remove test actor deadletter logging (#5662) * Modernize Receive function to switch instead of if...else * Remove TestActor DeadLetter logging Co-authored-by: Gregorius Soedharmo <[email protected]> * Extract ITestQueue<T> interface from BlockingQueue<T> (#5665) Co-authored-by: Gregorius Soedharmo <[email protected]> * [TEST] Add AsyncQueue to TestKit (#5672) * Moved the `akka core` configuration page into `modules`` (#5664) * Fix link issue with `xref` (#5666) Co-authored-by: Aaron Stannard <[email protected]> * [Docs]: Fix Metadata Reference (#5668) * Turn on `ProduceReferenceAssembly` * Add `ProduceReferenceAssembly` to `common.props` * Fix build failures in Akka.FSharp * Revert `<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>` added to affected projects because it already exists in `common.props' * Resolved invalid links (#5669) * Check for possible broken documentation by failing on DocFX warning (#5542) * Add --warningsAsErrors flag to DocFX * Add check in AzDo pr validation yaml * Use windows image for docfx test * Fix build script name * disable incremental builds for DocFx Co-authored-by: Aaron Stannard <[email protected]> * Removed internal copy of Nito.AsyncEx.AsyncContext, used the nuget package instead * Add asynchronous queue AsyncQueue to replace BlockingQueue * Remove <inheritdoc> XML doc tags, its causing DocFX crash Co-authored-by: Ebere Abanonu <[email protected]> Co-authored-by: Aaron Stannard <[email protected]> Co-authored-by: Gregorius Soedharmo <[email protected]> * Switch internal implementation to async (#5676) * Switch internal implementation to `async` * Revert changes on `ReceiveOne` methods * replaced `TryPeekAsync` and `TryTakeAsync` with their respective `sync` methods * Change Receive Test Methods to `Sync` over `Async` (#5678) * Changed to sync over async * * Change Peek methods to sync over async * Create Peek `async` mthods * Change FishForMessage() to sync over async that calls FishForMessageAsync() * Inherit doc from `FishForMessage` * Fix .Wait() returns AggregatedException instead of expected exxception Co-authored-by: Gregorius Soedharmo <[email protected]> * `AwaitAssert()` over `AwaitAssertAsync()` (#5683) * Converted `AwaitAssert()` to sync over async and called `AwaitAssertAsync()` * Added CancellationToken support * Prefer `ThrowIfCancellationRequested()` over `IsCancellationRequested` * `AwaitCondition()` over `AwaitConditionAsync()` (#5685) * Change `AwaitCondition()` to sync over async that calls `AwaitConditionAsync()` * Add CancellationToken support * Added `cancellationToken.IsCancellationRequested` check before var now with a different failure message. * Change ReceiveWhile Test Methods to Sync over Async (#5682) * Fix the remaining `FishForMessage` `Sync` over `Async` methods * * Changed `ReceiveWhile` to `Sync` over `Async` * Created `ReceiveWhileAsync()` * Add missing TBD * Create `ReceiveNAsync()` * Potential fix for DocFx `StackOverflow` exception * * Changed `FishForMessage` to directly call its `async` version * Fix possible cause of `Stackoverflow` exception - methods inheriting docs from itself. * Fix build error * Added `CancellationToken` support * Changed Receive methods to sync-over-async * Add CancellationToken support to InternalReceiveNAsync, remove non-async private InternalReceiveN Co-authored-by: Gregorius Soedharmo <[email protected]> * Changed Expect methods to call async version * Changed all `ExpectNoMsg()` methods to `sync-over-async` that calls their respective `async` methods * Return `InternalReceiveN` to its former state. * `.WaitAndUnwrapException()` is same as `.Result` - use `.WaitAndUnwrapException()` instead * `.WaitAndUnwrapException` is same with `.Result` - use `.WaitAndUnwrapException` to avoid deadlocks * Return `ReceiveN()` to being `sync-over-async` * Replaced `.Result` with `.WaitAndUnwrapException` to avoid blocking * Use `TryTake` * Cleanup code * Code cleanup * Code cleanup, fix Akka.Remote.Test ThrottleTransportAdapterSpec * Cherrypick codes * Rollback ConfigureAwait() removal * Fix ThrottlerTransportAdapterSpec, make the spec async * Update API Approval list * Update build system, use dll name instead of calling generic "dotnet test" on project file * Skip .Tests.Performance projects * Exclude *.Tests.Performance in CI/CD tests * Revert "Update build system, use dll name instead of calling generic "dotnet test" on project file" This reverts commit 6757de1. * Revert "Skip .Tests.Performance projects" This reverts commit 57a0eac. * Revert "Exclude *.Tests.Performance in CI/CD tests" This reverts commit 72926f4. * Turn off incremental build (need to turn this back on after merging to dev) * Change EventFilterApplier to async (#5698) Co-authored-by: Gregorius Soedharmo <[email protected]> Co-authored-by: Aaron Stannard <[email protected]> * [TEST] Change Within methods to async (#5701) * Change Within methods to async * Fix async Within * Fix documentation Co-authored-by: Gregorius Soedharmo <[email protected]> * [TEST] Fix and cleanup TestKit codes (#5704) * Fix and cleanup codes * Add missing `base.AfterAll()` in SerializationTransportInformationSpec Co-authored-by: Gregorius Soedharmo <[email protected]> * Implement ExpectMsgFrom as async (#5703) Co-authored-by: Gregorius Soedharmo <[email protected]> Co-authored-by: Aaron Stannard <[email protected]> * Turn incremental back on, use targetBranch to target feature/async_testkit branch for now (#5716) * Convert AwaitCondition in TestKitBase initializer, can not use `.Wait()` in ctor (#5721) * Convert Akka.Persistence.TestKit.Tests to async (#5718) * Convert Akka.Persistence.TestKit.Tests to async Co-authored-by: Aaron Stannard <[email protected]> * Fix spelling (#5745) (#5755) Co-authored-by: Ebere Abanonu <[email protected]> * Port `Akka.Tests.Actor.Stash` tests to `async/await` (#5754) * Port `Akka.Tests.Actor.Scheduler` tests to async/await (#5753) * Chnaged tests under Akka.Tests.Actor.Dispatch to async/await (#5752) Co-authored-by: Aaron Stannard <[email protected]> * Port `Akka.Tests.Actor.Scheduler` tests to `async/await` - 2 (#5756) * Port `Akka.Tests.Actor.Scheduler` tests to async/await * Port `Akka.Tests.Actor.Scheduler` tests to `async/await` - 2 * Make code neater * Port `Akka.Tests.Actor` tests to `async/await` (#5757) Co-authored-by: Aaron Stannard <[email protected]> * Port `Akka.Tests.Actor` tests to `async/await` - ActorCell (#5758) Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Actor` tests to `async/await` - `ActorDsl` (#5759) * Port `Akka.Tests.Actor` tests to `async/await` - `ActorLookup` (#5761) * Port `Akka.Tests.Actor` tests to `async/await` - `ProducerPipeline` (#5762) Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Actor` tests to `async/await` - ActorLifeCycle (#5760) * Port `Akka.Tests.Actor` tests to `async/await` - ActorLifeCycle * Fix OnReceive method Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Actor` tests to `async/await` - `ActorRefSpec` (#5764) * Port `Akka.Tests.Actor` tests to `async/await` - `ActorRefSpec` * Fix test intent Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Actor` tests to `async/await` - `CoordinatedShutdownSpec` (#5770) * Port `Akka.Tests.Actor` tests to `async/await` - `CoordinatedShutdownSpec` * Fix CoordinatedShutdown_must_abort_if_recover_is_off Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Actor` tests to `async/await` - `ActorSelectionSpec` (#5765) * Port `Akka.Tests.Actor` tests to `async/await` - ActorSelectionSpec * Fix test implementation * Revert changes to Akka.Util.Internal.Extensions to make CI/CD run faster Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Actor` tests to `async/await` - AskSpec (#5767) * Port `Akka.Tests.Actor` tests to `async/await` - AskSpec * Fix timeout code Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Actor` tests to `async/await` - RefIgnoreSpec (#5763) * Port `Akka.Tests.Actor` tests to `async/await` - RefIgnoreSpec * Fix missing cancellationToken default value Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Actor` tests to `async/await` - `BugFix4376Spec` (#5768) Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Actor` tests to async/await - `ActorSystemSpec` (#5766) * Port `Akka.Tests.Actor` tests to async/await - `ActorSystemSpec` * Replaced `Wait` with `AwaitWithTimeout` * Fix unit tests Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Actor` tests to `async/await` - `DeadLetter*Spec` (#5771) * Port `Akka.Tests.Actor` tests to `async/await` - `DeathWatchSpec` (#5772) * Port `Akka.Tests.Actor` tests to `async/await` - `DeathWatchSpec` * Fix test intention Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Actor` tests to `async/await` - `BugFix4823Spec` (#5769) * Port `Akka.Tests.Actor` tests to `async/await` - `BugFix4823Spec` * Removed ask-timeout code to make CI/CD work faster, will add this later Co-authored-by: Gregorius Soedharmo <[email protected]> * General API and global ask timeout setting fix (#5773) * Port `Akka.Tests.Actor` tests to `async/await` - `FSMActorSpec` (#5774) Co-authored-by: Aaron Stannard <[email protected]> * Port `Akka.Tests.Actor` tests to `async/await` - `FSMTimingSpec` (#5775) Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Actor` tests to `async/await` - `FSMTransitionSpec` (#5776) Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Actor` tests to `async/await` - `FunctionRefSpecs` (#5777) * Port `Akka.Tests.Actor` tests to `async/await` - `FunctionRefSpecs` * Make use of `Task` instead of `ValueTask` Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Actor` tests to `async/await` - `HotSwapSpec` (#5778) * Port `Akka.Tests.Actor` tests to `async/await` - `InboxSpec` (#5780) Co-authored-by: Gregorius Soedharmo <[email protected]> Co-authored-by: Aaron Stannard <[email protected]> * Port `Akka.Tests.Actor` tests to `async/await` - `LocalActorRefProviderSpec` (#5781) * Port `Akka.Tests.Actor` tests to `async/await` - `LocalActorRefProviderSpec` * Fix missing async test Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Actor` tests to `async/await` - `PipeToSupportSpec` (#5782) * Port `Akka.Tests.Actor` tests to `async/await` - `PipeToSupportSpec` * Fix async tests Co-authored-by: Gregorius Soedharmo <[email protected]> * Convert Akka.Streams.TestKit to async (#5793) * Port `Akka.Tests.Actor` tests to `async/await` - `ReceiveActorTests` (#5783) * Port `Akka.Tests.Actor` tests to `async/await` - `ReceiveTimeoutSpec` (#5784) Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Actor` tests to `async/await` - `SupervisorHierarchySpec` (#5785) * Port `Akka.Tests.Actor` tests to `async/await` - `SystemGuardianTests` (#5786) * Port `Akka.Tests.Actor` tests to `async/await` - `TimerSpec` (#5787) Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Dispatch` tests to `async/await` - `ActorAsyncAwaitSpec` (#5788) * Port `Akka.Tests.Dispatch` tests to `async/await` - `ActorAsyncAwaitSpec` * Add missing async test Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Dispatch` tests to `async/await` - `DispatchersSpec` (#5789) * Port `Akka.Tests.Event` tests to `async/await` - `EventBusSpec` (#5791) Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Event` tests to `async/await` - `LoggerSpec` (#5795) * Port `Akka.Tests.Dispatch` tests to `async/await` - `MailboxesSpec` (#5790) * Port `Akka.Tests.Dispatch` tests to `async/await` - `MailboxesSpec` * await `AwaitConditionAsync` * Resolves #5790 (comment) * Port `Akka.Tests.Event` tests to `async/await` - `EventStreamSpec` (#5794) * Port `Akka.Tests.Event` tests to `async/await` - `EventStreamSpec` * Revert `ForEach` await * Changed the last `XAssert` to `Assert` Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.IO` tests to `async/await` - `TcpListenerSpec` (#5797) * Port `Akka.Tests.IO` tests to `async/await` - `TcpListenerSpec` * Resolve #5797 (comment) Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.IO` tests to `async/await` - `TcpIntegrationSpec` (#5796) * Port `Akka.Tests.IO` tests to `async/await` - `TcpIntegrationSpec` * * Don't use async/await inside `ForEach` * Revert base.CreateTestProbe(); * Resolve #5796 (comment) * Resolve #5796 (comment) * Fix API Approval * Resolves #5796 (comment) * Reverse changes to Akka.Util.Internal.Extensions Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Loggers` tests to `async/await` - `LoggerSpec` (#5798) Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.IO` tests to `async/await` - `UdpConnectedIntegrationSpec` (#5799) * Port `Akka.Tests.IO` tests to `async/await` - `UdpIntegrationSpec` (#5800) * Port `Akka.Tests.IO` tests to `async/await` - `UdpListenerSpec` (#5801) * Port `Akka.Tests.IO` tests to `async/await` - `UdpListenerSpec` * Created `RunAsync` Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Pattern` tests to `async/await` - `BackoffOnRestartSupervisorSpec` (#5803) Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Pattern` tests to `async/await` - `BackoffSupervisorSpec` (#5804) * Port `Akka.Tests.Pattern` tests to `async/await` - `BackoffSupervisorSpec` * Mark possible racy source Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Routing` tests to `async/await` - `ConsistentHashingRouterSpec` (#5807) * Port `Akka.Tests.Routing` tests to `async/await` - `ConfiguredLocalRoutingSpec` (#5806) * Port `Akka.Tests.Pattern` tests to `async/await` - `ConfiguredLocalRoutingSpec` * Let `.ToListAsync()` be called after `.Cast<Udp.Received>()` Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Routing` tests to `async/await` - `RandomSpec` (#5809) Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Routing` tests to `async/await` - `ResizerSpec` (#5810) * Port `Akka.Tests.Routing` tests to `async/await` - `ResizerSpec` * Fix missing async ports Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Routing` tests to `async/await` - `RoundRobinSpec` (#5811) Co-authored-by: Gregorius Soedharmo <[email protected]> * Port `Akka.Tests.Routing` tests to `async/await` - `RouteeCreationSpec` (#5812) * Port `Akka.Tests.Routing` tests to `async/await` - `RoutingSpec` (#5813) * Port `Akka.Tests.Routing` tests to `async/await` - `ScatterGatherFirstCompletedSpec` (#5814) * Port `Akka.Tests.Routing` tests to `async/await` - `TailChoppingSpec` (#5815) * Port Akka.Tests.Actor.Stash.ActorWithStashSpec (#5825) * Port `Akka.Tests.Actor` tests to async/await - BugFix2176Spec (#5826) * Port Akka.Tests.Actor tests to async/await - ContextWatchWithSpec, ConfigurationSpec (#5827) Co-authored-by: Aaron Stannard <[email protected]> * Port Akka.Tests.Dispatch tests to async/await - ActorMailboxSpec (#5828) Co-authored-by: Aaron Stannard <[email protected]> * Port Akka.Tests.IO tests to async/await - SimpleDnsCacheSpec (#5829) Co-authored-by: Aaron Stannard <[email protected]> * Port Akka.Tests.Pattern tests to async/await - CircuitBreakerSpec (#5830) * Port Akka.Tests.Pattern tests to async/await - RetrySpec (#5831) * Port Akka.Tests.Util tests to async/await - Indexspec (#5832) * Port Akka.Tests.Util.Internal tests to async/await - InterlockedSpinTests (#5833) * Convert racy unit tests to async (#5713) * Convert racy unit tests to async * Code fixes * Convert Akka.Persistence.TestKit.Tests to async * Revert "Convert Akka.Persistence.TestKit.Tests to async" This reverts commit 91bf88c. Co-authored-by: Aaron Stannard <[email protected]> * Move Akka.Tests.Util.TaskHelper to Akka.TestKit.Extensions.TaskExtensions (#5851) * Convert Akka.TestKit.Tests to async - NoImplicitSenderSpec TestSchedulerSpec (#5853) * Convert TestKitBase and TestProbe to async (#5852) Co-authored-by: Aaron Stannard <[email protected]> * Add PrintTree method to ExtendedActorSystem (#5858) * Add PrintTree method to ExtendedActorSystem * Update approval list * Fix Akka.DistributedData.Tests.MultiNode ReplicatorPruningSpec (#5864) * Convert Xunit2.TestKit and AkkaSpec from IDisposable to IAsyncLifetime (#5865) * Convert Akka.TestKit,Tests.TestKitBaseTests.ReceiveTests to async (#5868) * Convert Akka.TestKit.Tests.TestKitBaseTests.DilatedTests to async (#5869) * Convert Akka.TestKit.Tests.TestKitBaseTests.AwaitAssertTests to async (#5870) * Convert Akka.TestKit.Tests.TestFSMRefTests.TestFSMRefSpec to async (#5871) * Convert Akka.TestKit.Tests.TestEventListenerTests to async (#5872) * Convert Akka.TestKit.Tests.TestEventListenerTests to async * Fix namespace and exception message pattern matching * Convert Akka.TestKit.Tests.TestKitBaseTests ExpectTests and IgnoreMessagesTests to async (#5876) * Convert Akka.Remote.Tests to async - UntrustedSpec (#5877) * Convert Akka.Remote.Tests to async - TransientSerializationErrorSpec (#5879) Co-authored-by: Aaron Stannard <[email protected]> * Convert Akka.Remote.Tests to async - Transport.AkkaProtocolSpec (#5880) * [Async TestKit] Convert Akka.Remote.Tests to async - RemotingTerminatorSpecs (#5884) * Convert Akka.Remote.Tests to async - RemotingTerminatorSpecs * change variable naming to meet naming convention * Convert Akka.Remote.Tests to async - RemotingSpec (#5885) Co-authored-by: Aaron Stannard <[email protected]> * Convert Akka.Remote.Tests to async - ActorsLeakSpec (#5892) * Convert Akka.Remote.Tests to async - Assorted small changes (#5891) * Convert Akka.Remote.Tests to async - AddressUidExtensionSpecs * Convert Akka.Remote.Tests to async - RemoteDaemonSpec * Convert Akka.Remote.Tests to async - Remove AkkaSpec dependency (#5900) * Convert Akka.Remote.Tests to async - Remove AkkaSpec dependency * Attempt to fix AkkaProtocolSpec racy spec - Make sure that volatile is accessed correctly - Make sure that Heartbeat() is called before value check * Fix racy condition * Convert Akka.Remote.Tests to async - RemoteWatcherSpec (#5886) Co-authored-by: Aaron Stannard <[email protected]> * [Async TestKit] Convert Akka.Remote.Tests to async - RemoteRouterSpec (#5887) * Convert Akka.Remote.Tests to async - RemoteRouterSpec * Remove net471 from target platform, IAsyncEnumerator is not compatible in linux builds * Convert Akka.Remote.Tests to async - RemoteMetricsSpec (#5888) * Convert Akka.Remote.Tests to async - AkkaProtocolStressTest (#5893) * Convert Akka.Remote.Tests to async - RemoteMessageLocalDeliverySpec (#5889) Co-authored-by: Aaron Stannard <[email protected]> * Convert Akka.Remote.Tests to async - BugFixes.BugFix4384Spec (#5905) * Convert Akka.Remote.Tests to async - RemoteDeathWatchSpec (#5890) * Convert Akka.Remote.Tests to async - Serialization.SerializationTransportInformationSpec (#5904) * Convert Akka.Remote.Tests to async - Transport.GenericTransportSpec (#5898) * Convert Akka.Remote.Tests to async - Transport.TestTransportSpec (#5899) * Convert Akka.Remote.Tests to async - DotNettySslSupportSpec (#5894) * Convert Akka.Remote.Tests to async - Transport.DotNettyTransportShutdownSpec (#5896) * [Async TestKit] Convert Akka.Remote.Tests to async - Transport.ThrottlerTransportAdapterSpec (#5901) * Convert Akka.Remote.Tests to async - Transport.ThrottlerTransportAdapterSpec * Refactor FluentAssertion to TestKit * [Async TestKit] Convert Akka.Stream.TestKit to async - Refactor TestKit.Tests (#5906) * Convert Akka.Stream.TestKit to async - Refactor TestKit.Tests * Remove hard coded magic string configuration loading via embedded resource * Skip problematic racy unit tests (for now) * Skip racy tests * Skip racy tests * [Async TestKit] Convert Akka.Stream.TestKit to async - BaseTwoStreamsSetup (#5907) * Convert Akka.Stream.TestKit to async - BaseTwoStreamsSetup * Skip racy tests * Skip racy specs * Convert Akka.Stream.TestKit to async - ChainSetup (#5909) * [Async TestKit] Convert Akka.Stream.TestKit to async - TestSubscriber (#5911) * Convert Akka.Stream.TestKit to async - TestSubscriber * Skip racy specs * [Async TestKit] Convert Akka.Stream.TestKit to async - ScriptedTest (#5910) * Convert Akka.Stream.TestKit to async - ScriptedTest * Fix initialization code * Convert Akka.Stream.TestKit to async - StreamTestKitSpec (#5912) * Convert Akka.Stream.TestKit to async - TestPublisherSubscriberSpec (#5913) * Convert Akka.Streams.Tests to async - BugSpec (#5915) * [Async TestKit] Convert Akka.Streams.Tests to async - FusingSpec (#5914) * Convert Akka.Streams.Tests to async - FusingSpec * Skip racy specs Co-authored-by: Aaron Stannard <[email protected]> * Convert Akka.Streams.Tests to async - OutputStreamSinkSpec (#5919) * Convert Akka.Streams.Tests to async - OutputStreamSourceSpec (#5918) * Refactor TestSubscriber fluent async builder (#5923) * Refactor TestSubscriber fluent async builder * Fix OutputStreamSourceSpec * Skip racy tests * Bump timeout value * Modify build.fsx dotnet test to target the assembly dll directly instead of targetting the .csproj file (#5924) * Convert Akka.Streams.Tests to async - Dsl.FutureFlattenSourceSpec (#5925) * Convert Akka.Streams.Tests to async - Dsl.FutureFlattenSourceSpec * Skip *.Tests.Performance NBench projects from test runs * [Async TestKit] Convert Akka.Streams.Tests to async - ActorMaterializerSpec (#5916) * Convert Akka.Streams.Tests to async - ActorMaterializerSpec * Skip all of RestartSpec for now, suspected deadlock * AutoDownSpec (#5937) * Cluste_aware_router (#5933) * Cluster Log Spec (#5938) * Cluster Domain Even Publisher (#5939) * SplitBrainResolverSpec (#5936) Co-authored-by: Aaron Stannard <[email protected]> * Cluster Heater (#5940) * Add async fluent builder feature to TestPublisher (#5934) * Add async fluent builder feature to TestPublisher * Revert build.fsx changes * [Async TestKit] Convert Akka.Streams.Tests to async - TcpSpec (#5917) * Convert Akka.Streams.Tests to async - TcpSpec * Increase wait delay time * Port akka/akka#26771 Co-authored-by: Aaron Stannard <[email protected]> * ExpectMsgAsync (#5932) Co-authored-by: Aaron Stannard <[email protected]> * Convert Akka.Streams.Tests to async - Dsl.HubSpec (#5935) Co-authored-by: Aaron Stannard <[email protected]> * Post-merge cleanup * Update API verify list * Post-merge fix and update API verify list * Fix XML doc * Post merge fix, docs * Fix XML Doc * Post merge fix * Post merge fix * Merge pull request #5954 from Arkatufus/feature/async_testkit Merge `dev` into `feature/async_testkit` Co-authored-by: Gregorius Soedharmo <[email protected]> Co-authored-by: Ebere Abanonu <[email protected]> Co-authored-by: Aaron Stannard <[email protected]> Co-authored-by: Ebere Abanonu <[email protected]> Co-authored-by: Ismael Hamed <[email protected]> Co-authored-by: Drew <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adrian Leonhard <[email protected]> Co-authored-by: Simon Cropp <[email protected]> Co-authored-by: zbynek001 <[email protected]>
Changes
Add --warningsAsErrors flag to DocFX argument
close #5528
Warnings Log
1-26-2022: 754 Warning(s)
2-4-2022: 702 Warning(s)
2-7-2022: 590 Warning(s)
2-8-2022: 411 Warning(s)
2-9-2022: 312 Warning(s)
2-11-2022: 41 Warning(s)
2-15-2022: 25 Warning(s)
NOTE
This PR WILL fail until we fix all of the DocFX warnings in our documentation.