-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
made GraphStageLogic.LogSource
virtual and change default StageLogic
LogSource
#5360
made GraphStageLogic.LogSource
virtual and change default StageLogic
LogSource
#5360
Conversation
Also, changed the default `LogSource` to be the output of the `Stage.ToString()` method. Right now all `GraphStageLogic` log sources default to just "Logic (akka://{ActorSystemName})"
Here's the akka.net/src/core/Akka.Streams/Shape.cs Lines 223 to 232 in 048ea84
Is this too noisy for the logs? cc @ismaelhamed |
GraphStageLogic.LogSource
virtualGraphStageLogic.LogSource
virtual and change default StageLogic
LogSource
erring on the side of less is more
@@ -839,6 +839,7 @@ protected GraphStageLogic(int inCount, int outCount) | |||
/// <param name="shape">TBD</param> | |||
protected GraphStageLogic(Shape shape) : this(shape.Inlets.Count(), shape.Outlets.Count()) | |||
{ | |||
LogSource = Akka.Event.LogSource.Create(shape); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided to just log the Shape.GetType
here instead - less verbose this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also, changed the default
LogSource
to be the output of theStage.ToString()
method. Right now allGraphStageLogic
log sources default to just "Logic (akka://{ActorSystemName})"